[ABW-3971] - Select factors for transactions #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giannis-rdx
reviewed
Dec 20, 2024
|
|
||
| data class FactorSourceInstanceCard( | ||
| val id: FactorSourceId.Hash, |
There was a problem hiding this comment.
The SecurityShieldBuilder in Sargon works with FactorSourceId so it's easier if we use it as well to prevent unnecessary conversion operations.
giannis-rdx
approved these changes
Dec 20, 2024
micbakos-rdx
approved these changes
Dec 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABW-3971
Description
This PR adds the factor selection screen and validation logic using the
SecurityShieldBuilderinstance. We need to hold the instance along the whole security shield setup flow andbuildthe shield at the end. For this, I definedSecurityShieldBuilderClient, an alternative to a sharedviewModel, with the benefit of keeping the UI unaware of the logic, because anyviewModelcan directly inject this component and perform the required operations on the same instance of theSecurityShieldBuilder. The clear/reset logic is yet to be defined (when needed).Video
Link