Fixes on responding to dApp and assertions #1290
Merged
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
commented
Dec 20, 2024
| @@ -268,8 +268,6 @@ class TransactionReviewViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| fun dismissTerminalErrorDialog() { | |||
| _state.update { it.copy(error = null) } | |||
There was a problem hiding this comment.
Error was consumed here, before having the chance to be sent to dApp.
micbakos-rdx
commented
Dec 20, 2024
| @@ -471,7 +471,7 @@ fun Throwable.getDappMessage(): String? { | |||
| "Wallet is using network ID: $currentNetworkId, request sent specified network ID: $requestNetworkId" | |||
| } | |||
|
|
|||
| else -> message | |||
| else -> message ?: cause?.message | |||
There was a problem hiding this comment.
Some errors carry a cause from the CommonException coming from sargon. This message can be passed back to the CE logs.
micbakos-rdx
commented
Dec 20, 2024
| @@ -326,7 +326,7 @@ class TransactionSubmitDelegateImpl @Inject constructor( | |||
| val fungibleAsset = (transferable.asset as? Asset.Fungible) ?: return@mapNotNull null | |||
|
|
|||
| TransactionGuarantee( | |||
| amount = amount.estimated, | |||
| amount = amount.guaranteed, | |||
There was a problem hiding this comment.
The amount in the builder is for guaranteed amounts and not for predicted.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description