-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3179] Add troubleshooting section and reorganise settings packages to match UI #884
[ABW-3179] Add troubleshooting section and reorganise settings packages to match UI #884
Conversation
7316c2f
to
7f1cf19
Compare
7f1cf19
to
465e9a0
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here the warning needs some more padding based on Zeplin screens?
And also the "key" icon should only be aligned to center of the title and subtitle, right? Not to the whole row? Again from what I see in Zeplin
Two thing also here:
- the big warning icon "Recovery required" should be clickable and to navigate to seed phrase screen?
- the Security Center screen is scrollable right? Because in this device is not and it looks like I could scroll it a bit to see some space under the configuration backup card.
) { | ||
SecurityCenterContent(modifier, onBackClick, onSecurityFactorsClick) | ||
val state by securityCenterViewModel.state.collectAsStateWithLifecycle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ just a reminder that here the collectAsStateWithLifecycle
is behaving as collectAsState
since you already collecting the state in the SecurityCenterViewModel
@giannis-rdx all the work related to security center and those warnings is being worked on right now as a separate ticket, which is in progress |
Description
This PR reorganises settings packages to match UI and fills in troubleshooting section. For now:
PR submission checklist