Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3179] Add troubleshooting section and reorganise settings packages to match UI #884

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

jakub-rdx
Copy link
Contributor

@jakub-rdx jakub-rdx commented Apr 15, 2024

Description

This PR reorganises settings packages to match UI and fills in troubleshooting section. For now:

  • support just launches email client.
  • discord item does not link to anywhere
  • add backup screen stub UI

PR submission checklist

  • I have verified that troubleshooting section was updated to new design

@jakub-rdx jakub-rdx changed the title add troubleshooting section and reorganise settings packages to match… [ABW-3179] Add troubleshooting section and reorganise settings packages to match UI Apr 15, 2024
@jakub-rdx jakub-rdx force-pushed the feature/ABW-3179-troubleshooting-settings-section branch from 7316c2f to 7f1cf19 Compare April 18, 2024 10:15
Base automatically changed from feature/ABW-3163-main-settings-redesign to main April 18, 2024 10:41
@jakub-rdx jakub-rdx force-pushed the feature/ABW-3179-troubleshooting-settings-section branch from 7f1cf19 to 465e9a0 Compare April 18, 2024 10:58
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Copy link
Contributor

@giannis-rdx giannis-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here the warning needs some more padding based on Zeplin screens?
And also the "key" icon should only be aligned to center of the title and subtitle, right? Not to the whole row? Again from what I see in Zeplin
Screenshot 2024-04-19 at 10 53 35 AM

Two thing also here:

  1. the big warning icon "Recovery required" should be clickable and to navigate to seed phrase screen?
  2. the Security Center screen is scrollable right? Because in this device is not and it looks like I could scroll it a bit to see some space under the configuration backup card.
Screenshot 2024-04-19 at 10 56 51 AM

) {
SecurityCenterContent(modifier, onBackClick, onSecurityFactorsClick)
val state by securityCenterViewModel.state.collectAsStateWithLifecycle()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ just a reminder that here the collectAsStateWithLifecycle is behaving as collectAsState since you already collecting the state in the SecurityCenterViewModel

@jakub-rdx
Copy link
Contributor Author

I think here the warning needs some more padding based on Zeplin screens? And also the "key" icon should only be aligned to center of the title and subtitle, right? Not to the whole row? Again from what I see in Zeplin Screenshot 2024-04-19 at 10 53 35 AM

Two thing also here:

  1. the big warning icon "Recovery required" should be clickable and to navigate to seed phrase screen?
  2. the Security Center screen is scrollable right? Because in this device is not and it looks like I could scroll it a bit to see some space under the configuration backup card.
Screenshot 2024-04-19 at 10 56 51 AM

@giannis-rdx all the work related to security center and those warnings is being worked on right now as a separate ticket, which is in progress

@jakub-rdx jakub-rdx merged commit b6fed22 into main Apr 19, 2024
7 of 9 checks passed
@jakub-rdx jakub-rdx deleted the feature/ABW-3179-troubleshooting-settings-section branch April 19, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants