Debug Only: Inspect FactorInstancesCache
#1391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
commented
Nov 19, 2024
| @@ -109,15 +109,6 @@ | |||
| "version" : "11.6.4" | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
should be reverted ofc... and updated to use Sargon once the needed branch is merged.
CyonAlexRDX
commented
Nov 19, 2024
| @@ -273,6 +273,8 @@ extension InteractionReview.Sections { | |||
| accountDepositSetting: accountDepositSetting, | |||
| accountDepositExceptions: accountDepositExceptions | |||
| ) | |||
| case .some(.deleteAccounts(accountAddresses: let accountAddresses)): | |||
| fatalError() | |||
There was a problem hiding this comment.
will go away when #1389 is merged and I rebase to main.
CyonAlexRDX
commented
Nov 19, 2024
| @@ -42,11 +42,11 @@ extension Account { | |||
| } | |||
|
|
|||
| mutating func hide() { | |||
| flags.append(.deletedByUser) | |||
| flags.append(.hiddenByUser) | |||
There was a problem hiding this comment.
will go away once rebased on main with changes from #1389
CyonAlexRDX
commented
Nov 19, 2024
| #else | ||
| shouldPrederiveInstances = false | ||
| #endif | ||
| return try await SargonOS.shared.newWallet(shouldPrederiveInstances: shouldPrederiveInstances) |
There was a problem hiding this comment.
@micbakos-rdx breaking change for Android, you need to pass shouldPrederiveInstances: false to newWallet once Sargon "FIP" PR is merged.
CyonAlexRDX
requested review from
matiasbzurovski,
GhenadieVP and
danvleju-rdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Blocked by radixdlt/sargon#254
Tip
Maybe not amazing TCA code, but this is a only a debug tool.
Update
newWalletto for DEBUG builds pre-derive factor instances for the BDFS (I have not modified any other Add Factor Source code to pre-derive, since we are not yet using SargonOS to add FactorSources - we are though, using SargonOS fornewWalletso we can pre-derive instances for the BDFS).The purpose of this is to make it possible for us to debug the contents of the FactorInstancesCache and also delete it and ensuring that the behaviour of Sargon is correct even with a deleted cache.
Screenshot
Demo (video)
RPReplay_Final1732014917.MP4