Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3967] Prepare Factor Sources flow #1409

Merged
merged 27 commits into from
Dec 6, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Dec 5, 2024

Jira ticket: ABW-3967

Description

Adds PrepareFactors flow as well as set up to coordinate among different flows.

Video

Video

@matiasbzurovski matiasbzurovski changed the title Abw 3967 not enough factors flow [ABW-3967] Prepare Factors flow Dec 5, 2024
@matiasbzurovski matiasbzurovski force-pushed the ABW-3967-not-enough-factors-flow branch from 014632b to d326aae Compare December 5, 2024 11:43
@matiasbzurovski matiasbzurovski marked this pull request as ready for review December 5, 2024 12:15
}

@MainActor
struct View: SwiftUI.View {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to own file

Copy link
Contributor

@danvleju-rdx danvleju-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Agree with moving the logic to Sargon.

@matiasbzurovski matiasbzurovski force-pushed the ABW-3967-not-enough-factors-flow branch from cb1b2c3 to 9d5d89f Compare December 5, 2024 17:31
@matiasbzurovski matiasbzurovski changed the title [ABW-3967] Prepare Factors flow [ABW-3967] Prepare Factor Sources flow Dec 6, 2024
@matiasbzurovski matiasbzurovski merged commit 3e47665 into main Dec 6, 2024
6 checks passed
@matiasbzurovski matiasbzurovski deleted the ABW-3967-not-enough-factors-flow branch December 6, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants