-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ABW-3967] Prepare Factor Sources flow #1409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
changed the title
Abw 3967 not enough factors flow
[ABW-3967] Prepare Factors flow
Dec 5, 2024
This reverts commit d230b5f.
matiasbzurovski
force-pushed
the
ABW-3967-not-enough-factors-flow
branch
from
December 5, 2024 11:43
014632b
to
d326aae
Compare
CyonAlexRDX
reviewed
Dec 5, 2024
RadixWallet/Clients/FactorSourcesClient/FactorSourcesClient+Interface.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Clients/FactorSourcesClient/FactorSourcesClient+Interface.swift
Outdated
Show resolved
Hide resolved
RadixWallet/Features/ShieldSetup/PrepareFactors/Children/AddFactor+View.swift
Outdated
Show resolved
Hide resolved
matiasbzurovski
commented
Dec 5, 2024
} | ||
|
||
@MainActor | ||
struct View: SwiftUI.View { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to own file
GhenadieVP
reviewed
Dec 5, 2024
RadixWallet/Clients/FactorSourcesClient/FactorSourcesClient+Interface.swift
Outdated
Show resolved
Hide resolved
danvleju-rdx
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Agree with moving the logic to Sargon.
RadixWallet/Features/ShieldSetup/PrepareFactors/Children/AddFactor+View.swift
Outdated
Show resolved
Hide resolved
matiasbzurovski
force-pushed
the
ABW-3967-not-enough-factors-flow
branch
from
December 5, 2024 17:31
cb1b2c3
to
9d5d89f
Compare
CyonAlexRDX
reviewed
Dec 6, 2024
RadixWallet/Features/ShieldSetup/PrepareFactors/Children/AddFactorSource+View.swift
Outdated
Show resolved
Hide resolved
danvleju-rdx
approved these changes
Dec 6, 2024
This reverts commit b207add.
matiasbzurovski
changed the title
[ABW-3967] Prepare Factors flow
[ABW-3967] Prepare Factor Sources flow
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3967
Description
Adds PrepareFactors flow as well as set up to coordinate among different flows.
Video
Video