[ABW-3918] Security Factors redesign #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
commented
Dec 9, 2024
| title: kind.title, | ||
| subtitle: kind.details, | ||
| hints: hints, | ||
| icon: .asset(kind.icon), |
There was a problem hiding this comment.
kind.icon is an ImageResource, and not an ImageAsset. This is what triggered all the changes that you can see on the PR (basically use ImageResource instead of ImageAsset in SettingsRow).
This is a good change anyway since we are using Swift's native type rather than a custom one from Swiftgen library
CyonAlexRDX
approved these changes
Dec 9, 2024
danvleju-rdx
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3918
Description
This PR updates the Security Factors screen to match new design.
Screenshot
Link