[ABW-4014] Bump TCA to 1.17.0 #1423
Conversation
| @@ -27,12 +27,12 @@ extension CloudBackupClient: TestDependencyKey { | |||
| ) | |||
|
|
|||
| static let testValue = Self( | |||
| isCloudProfileSyncEnabled: unimplemented("\(Self.self).isCloudProfileSyncEnabled"), | |||
| isCloudProfileSyncEnabled: noop.isCloudProfileSyncEnabled, | |||
There was a problem hiding this comment.
Why not use unimplemented(description:placeholder:)? Same for other occurrences.
There was a problem hiding this comment.
Because the tests where these clients are used fail when unimplemented is used
There was a problem hiding this comment.
Start the fail with the update to 1.17.0?
There was a problem hiding this comment.
maybe we can use Sargon .sample values for noop in most clients? The fact that we throw is just because we did not have sample value for most types before Sargon.
There was a problem hiding this comment.
That’s a good idea, but it’ll take some time to go through all the noops, so I’m leaving it as a future improvement.
| @@ -12,6 +12,6 @@ extension LocalAuthenticationClient: TestDependencyKey { | |||
| queryConfig: { .biometricsAndPasscodeSetUp }, | |||
| authenticateWithBiometrics: { true }, | |||
| setAuthenticatedSuccessfully: unimplemented("\(Self.self).setAuthenticatedSuccessfully"), | |||
| authenticatedSuccessfully: unimplemented("\(Self.self).authenticatedSuccessfully") | |||
| authenticatedSuccessfully: unimplemented("\(Self.self).authenticatedSuccessfully", placeholder: AsyncLazySequence([]).eraseToAnyAsyncSequence()) | |||
There was a problem hiding this comment.
better to define noop to follow the same pattern
Jira ticket: ABW-4014
Description
unimplementednow requires aplaceholderparameter for cases where the placeholder cannot be generated.swiftui-navigationhas been renamed toswift-navigation.