Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing slash #997

Closed
wants to merge 1 commit into from
Closed

remove trailing slash #997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/console/src/pages/navbar-pages/configure-metadata/ClaimedWebsiteStatus.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
if (isValidUrl(value)) {
http
.post('api/claimed-website', {
url: value,
url: value.endsWith('/') ? value.slice(0, -1) : value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the intention was to show validation error rather than silently change it for the user

For the developer console, I don't think we should be silently trying to make corrections like this. What the user enters is what is used. If there's a problem, we should show errors, but the user should fix themselves.
link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, this is not about checking it's status but rather what we put in the manifest and I don't see any changes about that?

expectedAddress: entityAddress
})
.then(({ output }) => {
Expand Down
Loading