Merge pull request #215 from radixdlt/fix-persona-data

fix: prevent error when personaData has empty arrays

src/data-request/transformations/wallet-data-to-connect-button.spec.ts

@@ -0,0 +1,32 @@
+
+import { transformWalletDataToConnectButton } from './wallet-data-to-connect-button'
+describe('transformWalletDataToConnectButton', () => {
+  describe('when persona data contain empty arrays', () => {
+    it('should not fail', () => {
+      // Arrange
+      const walletData = {
+        personaData: [
+          {
+            entry: 'emailAddresses',
+            fields: [],
+          },
+          {
+            entry: 'phoneNumbers',
+            fields: [],
+          },
+        ],
+      } as any
+
+      // Act
+      const result = transformWalletDataToConnectButton(walletData)
+
+      // Assert
+      expect(result).toEqual({
+        accounts: [],
+        personaLabel: '',
+        connected: false,
+        personaData: [],
+      })
+    })
+  })
+})

src/data-request/transformations/wallet-data-to-connect-button.ts

@@ -4,8 +4,8 @@ export const transformWalletDataToConnectButton = (walletData: WalletData) => {
   const accounts = walletData.accounts ?? []
   const personaLabel = walletData?.persona?.label ?? ''
   const connected = !!walletData?.persona
-  const personaData = walletData.personaData
-    .map((item) => {
+  const personaData = walletData?.personaData
+    ?.map((item) => {
       if (item.entry === 'fullName') {
         const { variant, givenNames, familyName, nickname } = item.fields
         const value =
@@ -34,11 +34,11 @@ export const transformWalletDataToConnectButton = (walletData: WalletData) => {
     })
     .filter(
       (
-        item
+        item,
       ): item is {
         value: string
         field: string
-      } => !!item && !!item.value.trim()
+      } => !!item && !!item.value?.trim(),
     )
 
   return { accounts, personaLabel, connected, personaData }