fix: rename setExpiration parameter

radixdlt · Nov 7, 2024 · a971f48 · a971f48
1 parent 0ed3b37
commit a971f48
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/examples/simple-dapp/src/main.ts b/examples/simple-dapp/src/main.ts
@@ -82,8 +82,7 @@ const proofOfOwnershipRequest = document.getElementById(
   'proof-of-ownership-request',
 )!
 
-let subintentExpiration: 'secondsAfterSignature' | 'atTime' =
-  'secondsAfterSignature'
+let subintentExpiration: 'afterDelay' | 'atTime' = 'afterDelay'
 
 document.querySelectorAll('input[name="option"]').forEach((radio) => {
   radio.addEventListener('change', () => {
@@ -92,9 +91,7 @@ document.querySelectorAll('input[name="option"]').forEach((radio) => {
     ) as HTMLInputElement
     if (selectedOption) {
       console.log(`Selected value: ${selectedOption.value}`)
-      subintentExpiration = selectedOption.value as
-        | 'secondsAfterSignature'
-        | 'atTime'
+      subintentExpiration = selectedOption.value as 'afterDelay' | 'atTime'
     }
   })
 })

diff --git a/...pp-toolkit/src/modules/wallet-request/pre-authorization-request/subintent-builder.spec.ts b/...pp-toolkit/src/modules/wallet-request/pre-authorization-request/subintent-builder.spec.ts
@@ -5,7 +5,7 @@ describe('SubintentRequestBuilder', () => {
   it('should build a subintent request', () => {
     const tx = SubintentRequestBuilder()
       .manifest('...')
-      .setExpiration('secondsAfterSignature', 60)
+      .setExpiration('afterDelay', 60)
       .addBlobs('deadbeef', 'beefdead')
       .message('hello')
       .toRequestItem()

diff --git a/...es/dapp-toolkit/src/modules/wallet-request/pre-authorization-request/subintent-builder.ts b/...es/dapp-toolkit/src/modules/wallet-request/pre-authorization-request/subintent-builder.ts
@@ -27,14 +27,11 @@ export const SubintentRequestBuilder = () => {
   /**
    * Sets the expiration for a request.
    *
-   * @param type - The type of expiration. Can be 'atTime' for a specific time or 'secondsAfterSignature' for a duration after the signature.
-   * @param value - The value associated with the expiration type. For 'atTime', this is a timestamp. For 'secondsAfterSignature', this is the number of seconds.
+   * @param type - The type of expiration. Can be 'atTime' for a specific time or 'afterDelay' for a duration after the signature.
+   * @param value - The value associated with the expiration type. For 'atTime', this is a timestamp. For 'afterDelay', this is the number of seconds.
    * @returns The API object for chaining.
    */
-  const setExpiration = (
-    type: 'atTime' | 'secondsAfterSignature',
-    value: number,
-  ) => {
+  const setExpiration = (type: 'atTime' | 'afterDelay', value: number) => {
     state.expiration =
       type === 'atTime'
         ? {