RDT-230-resolve-request #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
dawidsowardx
reviewed
Oct 3, 2024
...olkit/src/modules/wallet-request/transport/connector-extension/connector-extension.module.ts
Show resolved
Hide resolved
...olkit/src/modules/wallet-request/transport/connector-extension/connector-extension.module.ts
Show resolved
Hide resolved
xstelea
force-pushed
the
RDT-230-resolve-request
branch
from
0eb367a to
4e383c2
Compare
dawidsowardx
approved these changes
Oct 3, 2024
| return result | ||
| }, | ||
| .andThen((response) => { | ||
| if (connectResponseCallback) connectResponseCallback!(ok(response)) |
There was a problem hiding this comment.
if (connectResponseCallback) connectResponseCallback!
doesn't TS understand that and you need t assert with !?
| if (connectResponseCallback) connectResponseCallback!(ok(response)) | ||
| return ok(response) | ||
| }) | ||
| .orElse((error) => { |
There was a problem hiding this comment.
Is .orElse behaving any different than .mapErr in this scenario?
xstelea
force-pushed
the
RDT-230-resolve-request
branch
from
5d9803c to
01eed87
Compare
|
🎉 This PR is included in version 2.2.0-dev.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0-subintent.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.