Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README #280

Merged
merged 1 commit into from
Nov 27, 2024
Merged

docs: update README #280

merged 1 commit into from
Nov 27, 2024

Conversation

dawidsowardx
Copy link
Contributor

  • remove outdated content about dapp definition address
  • remove ROLA content and link to ROLA repository
  • extend information about connect button customization

@github-actions GitHub Actions
Copy link

Phylum Report Link

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/connect-button-storybook:sha-d5d0d76
docker.io/radixdlt/connect-button-storybook:pr-280

@dawidsowardx dawidsowardx force-pushed the update-readme branch 5 times, most recently from d92faa0 to 6c7247f Compare November 26, 2024 14:25
azizi-a
azizi-a requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@azizi-a azizi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of minor suggestions. Do we also want to update and link to packages/connect-button/README.md here?

packages/dapp-toolkit/README.md Show resolved Hide resolved
packages/dapp-toolkit/README.md Outdated Show resolved Hide resolved
@dawidsowardx dawidsowardx requested a review from azizi-a November 27, 2024 13:01
@dawidsowardx
docs: update README
9b32e96 
- remove outdated content about dapp definition address
- remove ROLA content and link to ROLA repository
- extend information about connect button customization
@dawidsowardx dawidsowardx merged commit 46fd40f into main Nov 27, 2024
16 checks passed
@dawidsowardx dawidsowardx deleted the update-readme branch November 27, 2024 15:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

🎉 This PR is included in version 2.2.0-dev.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizi-a azizi-a azizi-a approved these changes

Assignees
No one assigned
Labels
released on @dev released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawidsowardx @azizi-a