Remove bowser, add EnvironmentModule
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidsowardx
force-pushed
the
remove-bowser
branch
from
954e47f to
c6fdade
Compare
xstelea
reviewed
Dec 10, 2024
| @@ -0,0 +1,24 @@ | |||
| export type EnvironmentModule = ReturnType<typeof EnvironmentModule> | |||
| export const EnvironmentModule = () => { | |||
There was a problem hiding this comment.
can you move isTMA from deep link module into here?
xstelea
reviewed
Dec 10, 2024
packages/dapp-toolkit/src/_types.ts
Outdated
| @@ -25,12 +25,14 @@ import type { | |||
| ConnectButtonModule, | |||
| } from './modules' | |||
| import { BuildableSubintentRequest } from './modules/wallet-request/pre-authorization-request/subintent-builder' | |||
| import { EnvironmentModule } from './modules/environment' | |||
There was a problem hiding this comment.
import in same place where other modules are imported
xstelea
approved these changes
Dec 10, 2024
- remove bowser in favor of custom regex - use DI for `isMobile` and `isBrowser`
dawidsowardx
force-pushed
the
remove-bowser
branch
from
72d4a8e to
fe596ff
Compare
dawidsowardx
force-pushed
the
remove-bowser
branch
from
fe596ff to
3013378
Compare
|
🎉 This PR is included in version 2.2.0-dev.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isMobileandisBrowser