Skip to content

Commit

Permalink
Fix issue in Windows python bindings
Browse files Browse the repository at this point in the history
  • Loading branch information
0xOmarA committed Sep 22, 2023
1 parent 842ad3b commit bd4df6f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ jobs:
./interop/python/radix_engine_toolkit/x86_64-unknown-linux-gnu
cp \
./artifacts/radix-engine-toolkit-uniffi-x86_64-pc-windows-gnu/radix_engine_toolkit_uniffi.dll \
./interop/python/radix_engine_toolkit/x86_64-pc-windows-gnu
./interop/python/radix_engine_toolkit/x86_64-pc-windows-gnu.dll
- name: Build Package
working-directory: ./interop/python/
run: python3 -m build --wheel
Expand Down
5 changes: 4 additions & 1 deletion interop/python/replacement.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ def library_file_name() -> str:
elif is_arm and system == "Linux":
return "aarch64-unknown-linux-gnu"
elif is_x86 and system == "Windows":
return "x86_64-pc-windows-gnu"
# Either Windows or the Python runtime on Windows requires that DLLs
# have an extension of `.dll`. This is why this is the only dynamic
# library with an extension.
return "x86_64-pc-windows-gnu.dll"
else:
raise NotImplemented(f"No implementation of the Radix Engine Toolkit is available on your platform. Information detected: is_x86: {is_x86}, is_arm: {is_arm}, os: {system}")

Expand Down
4 changes: 2 additions & 2 deletions interop/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name="radix-engine-toolkit",
version="0.12.1dev3",
version="0.12.1dev4",
packages=["radix_engine_toolkit"],
author="radixdlt",
description="A Python wrapper around the Radix Engine Toolkit that provides Radix Ledger primitives to Python.",
Expand All @@ -24,7 +24,7 @@
"aarch64-apple-darwin",
"aarch64-unknown-linux-gnu",
"x86_64-apple-darwin",
"x86_64-pc-windows-gnu",
"x86_64-pc-windows-gnu.dll",
"x86_64-unknown-linux-gnu",
]
},
Expand Down

0 comments on commit bd4df6f

Please sign in to comment.