Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test / formatting tweaks/fixes #1879

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Minor test / formatting tweaks/fixes #1879

merged 3 commits into from
Aug 20, 2024

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Aug 18, 2024

Summary

Copy link

Phylum Report Link

Copy link

github-actions bot commented Aug 18, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:7116cd88aa

Copy link

Benchmark for 7116cd8

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 66.8±4.30ms 63.6±0.12ms -4.79%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.00ms 19.3±0.00ms -1.53%
costing::decode_encoded_i8_array_to_manifest_value 41.3±0.10ms 42.0±0.07ms +1.69%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.4±0.06ms 61.2±0.13ms -3.47%
costing::decode_encoded_tuple_array_to_manifest_value 100.4±0.19ms 119.1±1.07ms +18.63%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.9±0.07µs 26.2±0.04µs +1.16%
costing::decode_encoded_u8_array_to_manifest_value 41.3±0.09ms 41.9±0.10ms +1.45%
costing::decode_rpd_to_manifest_raw_value 12.5±0.02µs 12.9±0.02µs +3.20%
costing::decode_rpd_to_manifest_value 11.4±0.02µs 10.9±0.02µs -4.39%
costing::deserialize_wasm 1250.0±2.68µs 1286.7±8.01µs +2.94%
costing::execute_transaction_creating_big_vec_substates 708.2±10.01ms 713.8±12.37ms +0.79%
costing::execute_transaction_reading_big_vec_substates 577.1±1.65ms 581.2±1.01ms +0.71%
costing::instantiate_flash_loan 817.0±208.87µs 1219.7±2897.61µs +49.29%
costing::instantiate_radiswap 869.4±426.08µs 837.0±225.96µs -3.73%
costing::spin_loop 21.2±0.05ms 20.8±0.04ms -1.89%
costing::validate_sbor_payload 32.6±0.06µs 32.5±0.08µs -0.31%
costing::validate_sbor_payload_bytes 242.8±0.47ns 245.6±0.57ns +1.15%
costing::validate_secp256k1 76.6±0.10µs 76.6±0.07µs 0.00%
costing::validate_wasm 33.6±0.05ms 34.3±0.06ms +2.08%
decimal::add/0 8.4±0.00ns 8.4±0.01ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.01ns 0.00%
decimal::add/wasmi 218.0±0.74ns 220.0±0.56ns +0.92%
decimal::add/wasmi-call-native 2.1±0.01µs 2.1±0.00µs 0.00%
decimal::div/0 187.3±0.10ns 186.7±0.22ns -0.32%
decimal::from_string/0 163.0±0.22ns 161.4±0.32ns -0.98%
decimal::mul/0 150.5±0.35ns 148.6±0.13ns -1.26%
decimal::mul/rust-native 146.5±0.21ns 146.5±0.22ns 0.00%
decimal::mul/wasmi 10.5±0.05µs 11.0±0.08µs +4.76%
decimal::mul/wasmi-call-native 2.2±0.00µs 2.2±0.00µs 0.00%
decimal::pow/0 711.6±1.41ns 706.6±0.35ns -0.70%
decimal::pow/rust-native 662.9±0.37ns 663.8±0.97ns +0.14%
decimal::pow/wasmi 50.7±0.14µs 53.4±0.28µs +5.33%
decimal::pow/wasmi-call-native 2.4±0.00µs 2.4±0.01µs 0.00%
decimal::root/0 7.7±0.02µs 7.7±0.02µs 0.00%
decimal::sub/0 8.1±0.00ns 8.1±0.00ns 0.00%
decimal::to_string/0 431.9±0.42ns 434.1±0.44ns +0.51%
precise_decimal::add/0 8.8±0.01ns 9.1±0.00ns +3.41%
precise_decimal::add/rust-native 10.7±0.01ns 10.7±0.01ns 0.00%
precise_decimal::add/wasmi 261.2±0.78ns 264.8±0.49ns +1.38%
precise_decimal::add/wasmi-call-native 2.7±0.01µs 2.7±0.01µs 0.00%
precise_decimal::div/0 316.4±0.25ns 318.1±0.36ns +0.54%
precise_decimal::from_string/0 232.6±0.29ns 216.4±0.33ns -6.96%
precise_decimal::mul/0 362.0±0.29ns 364.7±0.74ns +0.75%
precise_decimal::mul/rust-native 319.7±1.57ns 320.8±0.21ns +0.34%
precise_decimal::mul/wasmi 29.8±0.22µs 30.6±0.06µs +2.68%
precise_decimal::mul/wasmi-call-native 3.1±0.01µs 3.2±0.01µs +3.23%
precise_decimal::pow/0 1955.7±5.14ns 1968.6±4.88ns +0.66%
precise_decimal::pow/rust-native 1530.9±3.26ns 1555.0±5.10ns +1.57%
precise_decimal::pow/wasmi 147.6±0.70µs 148.2±0.36µs +0.41%
precise_decimal::pow/wasmi-call-native 5.5±0.01µs 5.5±0.02µs 0.00%
precise_decimal::root/0 55.7±0.01µs 56.2±0.05µs +0.90%
precise_decimal::sub/0 8.9±0.07ns 9.2±0.00ns +3.37%
precise_decimal::to_string/0 704.7±2.79ns 694.1±1.24ns -1.50%
schema::validate_payload 380.5±0.60µs 381.9±0.58µs +0.37%
transaction::radiswap 5.2±0.02ms 5.2±0.05ms 0.00%
transaction::transfer 1923.5±3.10µs 1920.9±5.19µs -0.14%
transaction_processing::prepare 2.3±0.00ms 2.4±0.00ms +4.35%
transaction_processing::prepare_and_decompile 6.0±0.02ms 6.1±0.01ms +1.67%
transaction_processing::prepare_and_decompile_and_recompile 24.4±0.21ms 29.0±1.04ms +18.85%
transaction_validation::validate_manifest 42.8±0.03µs 43.1±0.05µs +0.70%
transaction_validation::verify_bls_2KB 1038.6±28.00µs 1074.3±21.92µs +3.44%
transaction_validation::verify_bls_32B 1005.3±20.27µs 1039.7±23.71µs +3.42%
transaction_validation::verify_ecdsa 74.6±0.04µs 74.6±0.04µs 0.00%
transaction_validation::verify_ed25519 55.6±0.12µs 55.6±0.09µs 0.00%

@dhedey dhedey merged commit f7333d6 into develop Aug 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants