Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some tx validator methods public #1989

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented Oct 30, 2024

Summary

Changed the visibility on some of the tx validator methods so that they're public.

Copy link

github-actions bot commented Oct 30, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:c03ba6af1a

Copy link

Benchmark for c03ba6a

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.1±0.21ms 44.2±0.18ms +0.23%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.4±0.08ms 19.4±0.09ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 42.5±0.05ms 41.6±0.07ms -2.12%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.3±0.23ms 71.2±0.17ms -1.52%
costing::decode_encoded_tuple_array_to_manifest_value 98.9±0.13ms 98.7±0.17ms -0.20%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.7±0.15µs 32.5±0.13µs +26.46%
costing::decode_encoded_u8_array_to_manifest_value 42.5±0.05ms 41.6±0.09ms -2.12%
costing::decode_rpd_to_manifest_raw_value 14.5±0.04µs 14.9±0.06µs +2.76%
costing::decode_rpd_to_manifest_value 11.0±0.11µs 10.8±0.08µs -1.82%
costing::deserialize_wasm 1225.2±7.51µs 1210.3±4.93µs -1.22%
costing::execute_transaction_creating_big_vec_substates 695.6±8.38ms 689.4±9.75ms -0.89%
costing::execute_transaction_reading_big_vec_substates 597.4±1.50ms 631.0±1.07ms +5.62%
costing::instantiate_flash_loan 992.1±1249.88µs 966.2±743.17µs -2.61%
costing::instantiate_radiswap 947.7±863.24µs 889.4±260.54µs -6.15%
costing::scrypto_malloc 461.5±1.25ms 468.0±0.80ms +1.41%
costing::scrypto_sbor_decode 481.9±3.20ms 493.8±3.54ms +2.47%
costing::scrypto_sha256 354.3±1.23ms 358.3±0.98ms +1.13%
costing::spin_loop_v1 466.9±1.38ms 474.5±0.37ms +1.63%
costing::spin_loop_v2 949.6±19.94ms 957.3±1.10ms +0.81%
costing::validate_sbor_payload 29.3±0.13µs 32.1±0.10µs +9.56%
costing::validate_sbor_payload_bytes 254.9±0.50ns 252.3±0.72ns -1.02%
costing::validate_secp256k1 76.6±0.07µs 76.7±0.13µs +0.13%
costing::validate_wasm 33.6±0.12ms 33.4±0.04ms -0.60%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.02ns 9.8±0.07ns 0.00%
decimal::add/wasmi 221.9±1.05ns 230.8±0.29ns +4.01%
decimal::add/wasmi-call-native 2.1±0.00µs 2.1±0.00µs 0.00%
decimal::div/0 173.1±0.42ns 168.8±0.17ns -2.48%
decimal::from_string/0 156.0±0.22ns 155.9±0.14ns -0.06%
decimal::mul/0 129.6±0.34ns 129.4±0.43ns -0.15%
decimal::mul/rust-native 128.1±0.12ns 126.0±0.20ns -1.64%
decimal::mul/wasmi 11.5±0.08µs 11.4±0.19µs -0.87%
decimal::mul/wasmi-call-native 2.2±0.00µs 2.3±0.00µs +4.55%
decimal::pow/0 595.2±0.41ns 593.7±0.38ns -0.25%
decimal::pow/rust-native 593.3±2.19ns 590.2±1.27ns -0.52%
decimal::pow/wasmi 59.7±0.21µs 62.0±0.30µs +3.85%
decimal::pow/wasmi-call-native 3.2±0.01µs 3.2±0.01µs 0.00%
decimal::root/0 8.0±0.02µs 8.0±0.01µs 0.00%
decimal::sub/0 8.3±0.00ns 8.3±0.01ns 0.00%
decimal::to_string/0 441.0±0.30ns 437.1±0.12ns -0.88%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.1±0.03ms 6.2±0.02ms +1.64%
large_transaction_processing::prepare_and_decompile_and_recompile 31.7±0.41ms 30.7±1.46ms -3.15%
metadata_validation::validate_urls 5.4±0.16µs 5.0±0.09µs -7.41%
precise_decimal::add/0 8.9±0.01ns 8.9±0.01ns 0.00%
precise_decimal::add/rust-native 10.7±0.01ns 11.0±0.43ns +2.80%
precise_decimal::add/wasmi 276.9±1.26ns 301.8±1.33ns +8.99%
precise_decimal::add/wasmi-call-native 2.9±0.00µs 2.8±0.00µs -3.45%
precise_decimal::div/0 315.2±2.87ns 287.8±0.40ns -8.69%
precise_decimal::from_string/0 201.3±0.27ns 201.3±0.35ns 0.00%
precise_decimal::mul/0 356.0±3.69ns 331.0±0.36ns -7.02%
precise_decimal::mul/rust-native 284.7±0.24ns 291.1±0.39ns +2.25%
precise_decimal::mul/wasmi 33.4±0.35µs 34.0±0.14µs +1.80%
precise_decimal::mul/wasmi-call-native 3.2±0.02µs 3.2±0.01µs 0.00%
precise_decimal::pow/0 1817.8±6.85ns 1766.0±6.07ns -2.85%
precise_decimal::pow/rust-native 1372.7±2.08ns 1370.1±1.42ns -0.19%
precise_decimal::pow/wasmi 165.2±1.31µs 162.8±0.25µs -1.45%
precise_decimal::pow/wasmi-call-native 5.4±0.02µs 5.4±0.02µs 0.00%
precise_decimal::root/0 57.8±0.02µs 58.9±0.07µs +1.90%
precise_decimal::sub/0 9.2±0.01ns 9.2±0.04ns 0.00%
precise_decimal::to_string/0 693.1±0.79ns 694.4±1.44ns +0.19%
schema::validate_payload 383.2±0.69µs 395.4±1.14µs +3.18%
transaction::radiswap 4.8±0.03ms 4.8±0.02ms 0.00%
transaction::transfer 1840.8±4.17µs 1817.5±16.21µs -1.27%
transaction_validation::validate_manifest 43.2±0.08µs 43.1±0.13µs -0.23%
transaction_validation::verify_bls_2KB 1030.4±32.72µs 1001.8±7.55µs -2.78%
transaction_validation::verify_bls_32B 1005.0±9.20µs 1005.3±13.58µs +0.03%
transaction_validation::verify_ecdsa 75.0±0.07µs 74.6±0.08µs -0.53%
transaction_validation::verify_ed25519 42.8±0.08µs 46.4±0.10µs +8.41%

@0xOmarA 0xOmarA merged commit 4078f68 into develop Oct 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants