Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak/cuttlefish manifest representation #1998

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Nov 10, 2024

Summary

Adjusts the canonical manifest representation, and SBOR encodings for strings.

Base branch needs updating when #1997 is merged.

Testing

Existing tests pass. Some new tests added to e2e.rs.

Copy link

github-actions bot commented Nov 10, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:ca26ec8f21

Copy link

github-actions bot commented Nov 10, 2024

Benchmark for ca26ec8

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.3±0.29ms 45.2±0.09ms +2.03%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.02ms 19.3±0.01ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 41.4±0.04ms 41.5±0.05ms +0.24%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.0±0.06ms 63.0±0.11ms 0.00%
costing::decode_encoded_tuple_array_to_manifest_value 119.8±1.10ms 120.4±1.03ms +0.50%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.7±0.06µs 25.8±0.10µs +0.39%
costing::decode_encoded_u8_array_to_manifest_value 41.4±0.09ms 41.5±0.06ms +0.24%
costing::decode_rpd_to_manifest_raw_value 12.4±0.04µs 12.5±0.04µs +0.81%
costing::decode_rpd_to_manifest_value 11.0±0.06µs 11.0±0.04µs 0.00%
costing::deserialize_wasm 1205.6±10.74µs 1210.1±5.92µs +0.37%
costing::execute_transaction_creating_big_vec_substates 691.3±8.56ms 705.2±9.69ms +2.01%
costing::execute_transaction_reading_big_vec_substates 599.4±1.26ms 600.8±0.56ms +0.23%
costing::instantiate_flash_loan 872.0±259.78µs 899.3±607.76µs +3.13%
costing::instantiate_radiswap 901.5±310.39µs 1087.1±1728.57µs +20.59%
costing::scrypto_malloc 508.0±0.72ms 518.8±1.88ms +2.13%
costing::scrypto_sbor_decode 527.8±2.07ms 540.2±1.40ms +2.35%
costing::scrypto_sha256 445.1±1.82ms 452.1±1.53ms +1.57%
costing::spin_loop_v1 455.2±5.56ms 438.7±1.45ms -3.62%
costing::spin_loop_v2 542.1±0.71ms 568.3±0.78ms +4.83%
costing::validate_sbor_payload 29.3±0.09µs 30.1±0.08µs +2.73%
costing::validate_sbor_payload_bytes 261.2±2.08ns 243.8±0.64ns -6.66%
costing::validate_secp256k1 76.7±0.07µs 76.7±0.08µs 0.00%
costing::validate_wasm 33.4±0.04ms 33.4±0.04ms 0.00%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 224.7±0.32ns 219.2±0.18ns -2.45%
decimal::add/wasmi-call-native 2.1±0.00µs 2.2±0.01µs +4.76%
decimal::div/0 169.2±0.35ns 168.4±0.10ns -0.47%
decimal::from_string/0 156.3±0.16ns 157.0±0.15ns +0.45%
decimal::mul/0 129.6±0.13ns 128.3±0.10ns -1.00%
decimal::mul/rust-native 127.6±0.14ns 127.0±0.06ns -0.47%
decimal::mul/wasmi 11.4±0.08µs 11.6±0.11µs +1.75%
decimal::mul/wasmi-call-native 2.3±0.00µs 2.2±0.00µs -4.35%
decimal::pow/0 594.5±0.37ns 594.7±0.54ns +0.03%
decimal::pow/rust-native 589.9±0.23ns 592.2±0.22ns +0.39%
decimal::pow/wasmi 58.2±0.33µs 58.7±0.65µs +0.86%
decimal::pow/wasmi-call-native 3.2±0.00µs 3.2±0.01µs 0.00%
decimal::root/0 8.3±0.01µs 8.3±0.01µs 0.00%
decimal::sub/0 8.3±0.00ns 8.2±0.00ns -1.20%
decimal::to_string/0 441.9±0.12ns 445.7±0.32ns +0.86%
large_transaction_processing::prepare 2.7±0.00ms 2.6±0.00ms -3.70%
large_transaction_processing::prepare_and_decompile 6.2±0.02ms 6.2±0.03ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 28.6±1.38ms 28.1±3.60ms -1.75%
metadata_validation::validate_urls 4.9±0.13µs 5.0±0.02µs +2.04%
precise_decimal::add/0 8.8±0.09ns 8.9±0.02ns +1.14%
precise_decimal::add/rust-native 10.8±0.21ns 10.8±0.26ns 0.00%
precise_decimal::add/wasmi 284.7±0.32ns 282.4±0.32ns -0.81%
precise_decimal::add/wasmi-call-native 2.9±0.00µs 2.8±0.01µs -3.45%
precise_decimal::div/0 286.5±1.33ns 296.0±0.79ns +3.32%
precise_decimal::from_string/0 203.9±0.20ns 202.1±0.23ns -0.88%
precise_decimal::mul/0 330.3±0.50ns 335.2±0.97ns +1.48%
precise_decimal::mul/rust-native 286.7±0.31ns 287.3±0.36ns +0.21%
precise_decimal::mul/wasmi 34.9±0.52µs 33.5±0.16µs -4.01%
precise_decimal::mul/wasmi-call-native 3.2±0.01µs 3.1±0.01µs -3.13%
precise_decimal::pow/0 1731.8±1.58ns 1729.9±2.72ns -0.11%
precise_decimal::pow/rust-native 1358.0±1.14ns 1354.7±1.24ns -0.24%
precise_decimal::pow/wasmi 168.5±0.30µs 161.7±1.01µs -4.04%
precise_decimal::pow/wasmi-call-native 5.4±0.01µs 5.4±0.01µs 0.00%
precise_decimal::root/0 58.0±0.05µs 57.7±0.03µs -0.52%
precise_decimal::sub/0 9.0±0.20ns 9.2±0.11ns +2.22%
precise_decimal::to_string/0 743.0±1.59ns 744.3±2.83ns +0.17%
schema::validate_payload 381.8±0.74µs 392.0±1.47µs +2.67%
transaction::radiswap 4.9±0.02ms 4.9±0.03ms 0.00%
transaction::transfer 1840.3±3.54µs 1857.4±3.53µs +0.93%
transaction_validation::validate_manifest 43.0±0.05µs 43.2±0.04µs +0.47%
transaction_validation::verify_bls_2KB 1009.4±30.78µs 1063.9±16.58µs +5.40%
transaction_validation::verify_bls_32B 1002.4±8.70µs 1094.9±24.82µs +9.23%
transaction_validation::verify_ecdsa 74.6±0.07µs 74.6±0.22µs 0.00%
transaction_validation::verify_ed25519 42.0±0.08µs 44.5±0.11µs +5.95%

@dhedey dhedey marked this pull request as ready for review November 10, 2024 20:50
@dhedey dhedey changed the base branch from feature/improved-error-rendering to develop November 11, 2024 16:51
@dhedey dhedey merged commit 423e26a into develop Nov 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants