Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further additional cuttlefish tests #2017

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Nov 26, 2024

Summary

  • Add demonstration of hash structure of NotarizedTransactionV2
  • Adds tests for encoding/decoding manifests
  • Adds ContextualDisplay to TransactionValidationError

Copy link

github-actions bot commented Nov 26, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:afec672dce

Copy link

Benchmark for afec672

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.5±0.20ms 44.8±0.07ms +0.67%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.03ms 19.6±0.04ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 41.3±0.05ms 41.4±0.10ms +0.24%
costing::decode_encoded_tuple_array_to_manifest_raw_value 71.4±0.15ms 71.1±0.11ms -0.42%
costing::decode_encoded_tuple_array_to_manifest_value 119.0±1.17ms 119.3±1.09ms +0.25%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.4±0.06µs 31.3±0.13µs +23.23%
costing::decode_encoded_u8_array_to_manifest_value 41.3±0.05ms 41.2±0.06ms -0.24%
costing::decode_rpd_to_manifest_raw_value 14.7±0.05µs 14.6±0.05µs -0.68%
costing::decode_rpd_to_manifest_value 10.7±0.02µs 10.8±0.08µs +0.93%
costing::deserialize_wasm 1217.0±7.17µs 1219.5±4.37µs +0.21%
costing::execute_transaction_creating_big_vec_substates 690.8±7.11ms 683.8±8.34ms -1.01%
costing::execute_transaction_reading_big_vec_substates 590.0±0.95ms 626.3±0.88ms +6.15%
costing::instantiate_flash_loan 834.2±223.02µs 881.7±618.97µs +5.69%
costing::instantiate_radiswap 837.6±305.47µs 815.3±160.35µs -2.66%
costing::scrypto_malloc 657.1±2.04ms 735.8±2.41ms +11.98%
costing::scrypto_sbor_decode 656.3±2.18ms 695.3±5.98ms +5.94%
costing::scrypto_sha256 583.4±0.88ms 603.5±0.67ms +3.45%
costing::spin_loop_v1 516.7±17.56ms 567.1±6.02ms +9.75%
costing::spin_loop_v2 604.7±10.62ms 600.0±3.06ms -0.78%
costing::validate_sbor_payload 29.5±0.05µs 30.4±0.65µs +3.05%
costing::validate_sbor_payload_bytes 245.1±0.62ns 256.0±2.14ns +4.45%
costing::validate_secp256k1 76.5±0.08µs 76.4±0.05µs -0.13%
costing::validate_wasm 33.4±0.03ms 33.8±0.05ms +1.20%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 321.6±1.22ns 313.0±2.15ns -2.67%
decimal::add/wasmi-call-native 2.9±0.00µs 3.0±0.00µs +3.45%
decimal::div/0 168.4±0.14ns 168.9±0.15ns +0.30%
decimal::from_string/0 154.8±0.08ns 156.0±0.08ns +0.78%
decimal::mul/0 127.6±0.03ns 129.5±0.10ns +1.49%
decimal::mul/rust-native 126.9±0.07ns 128.5±0.09ns +1.26%
decimal::mul/wasmi 19.5±0.05µs 18.6±0.08µs -4.62%
decimal::mul/wasmi-call-native 3.0±0.01µs 3.1±0.01µs +3.33%
decimal::pow/0 592.5±0.25ns 591.0±0.58ns -0.25%
decimal::pow/rust-native 590.3±0.20ns 592.6±0.23ns +0.39%
decimal::pow/wasmi 90.4±0.18µs 88.3±0.31µs -2.32%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.9±0.01µs +2.08%
decimal::root/0 8.1±0.01µs 8.4±0.01µs +3.70%
decimal::sub/0 8.2±0.00ns 8.2±0.00ns 0.00%
decimal::to_string/0 439.9±0.18ns 440.1±0.39ns +0.05%
large_transaction_processing::prepare 2.5±0.00ms 2.6±0.00ms +4.00%
large_transaction_processing::prepare_and_decompile 6.2±0.01ms 6.2±0.01ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 32.1±0.30ms 25.3±0.09ms -21.18%
metadata_validation::validate_urls 5.0±0.04µs 4.9±0.11µs -2.00%
precise_decimal::add/0 8.9±0.02ns 8.6±0.00ns -3.37%
precise_decimal::add/rust-native 10.9±0.31ns 10.6±0.01ns -2.75%
precise_decimal::add/wasmi 431.2±1.94ns 423.5±1.78ns -1.79%
precise_decimal::add/wasmi-call-native 3.8±0.02µs 3.9±0.00µs +2.63%
precise_decimal::div/0 287.1±0.32ns 293.2±2.53ns +2.12%
precise_decimal::from_string/0 201.2±0.43ns 205.4±0.43ns +2.09%
precise_decimal::mul/0 329.2±0.24ns 337.2±2.01ns +2.43%
precise_decimal::mul/rust-native 289.8±0.87ns 283.9±0.59ns -2.04%
precise_decimal::mul/wasmi 48.1±0.06µs 46.8±0.11µs -2.70%
precise_decimal::mul/wasmi-call-native 4.2±0.03µs 4.3±0.00µs +2.38%
precise_decimal::pow/0 1726.0±2.09ns 1721.3±2.01ns -0.27%
precise_decimal::pow/rust-native 1356.5±1.43ns 1355.3±0.64ns -0.09%
precise_decimal::pow/wasmi 229.4±0.35µs 227.1±0.26µs -1.00%
precise_decimal::pow/wasmi-call-native 7.6±0.03µs 7.6±0.01µs 0.00%
precise_decimal::root/0 58.7±0.05µs 57.7±0.03µs -1.70%
precise_decimal::sub/0 9.2±0.01ns 8.9±0.04ns -3.26%
precise_decimal::to_string/0 693.7±0.94ns 700.8±0.32ns +1.02%
schema::validate_payload 389.8±0.33µs 385.6±0.45µs -1.08%
transaction::radiswap 5.1±0.04ms 4.9±0.02ms -3.92%
transaction::transfer 1793.8±3.62µs 1828.9±5.41µs +1.96%
transaction_validation::validate_manifest 43.0±0.03µs 43.0±0.04µs 0.00%
transaction_validation::verify_bls_2KB 989.5±12.14µs 999.9±30.99µs +1.05%
transaction_validation::verify_bls_32B 977.9±11.44µs 999.7±6.21µs +2.23%
transaction_validation::verify_ecdsa 74.4±0.05µs 74.4±0.03µs 0.00%
transaction_validation::verify_ed25519 42.4±0.10µs 44.2±0.08µs +4.25%

@iamyulong iamyulong changed the base branch from release/cuttlefish to develop December 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants