Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ci for scrypto-dev-container docker target #2034

Draft
wants to merge 1 commit into
base: release/cuttlefish
Choose a base branch
from

Conversation

azizi-a
Copy link
Contributor

@azizi-a azizi-a commented Dec 3, 2024

Important

  • Please read our Contributing Guidelines before opening a PR.
  • Before creating your PR, please ensure you read the node branching strategy, which is also used in this repository. The end result after completing the merge actions should be that main <= release/XXX <= develop, where XXX is the latest released protocol version. This ensures that we minimise merge conflicts, and that work doesn't go missing.
  • As per the branching strategy, you must ensure you select the correct base branch, both for branching from, and in the PR UI above. The following process can be used to decide the base branch:
    • For code changes which can wait until the next protocol update to be released, use develop. This should be the default for code changes.
    • For code changes which need to go out as a fully-interoperable update to the node at the current protocol version, use release/XXX.
      • Such changes must be tested and reviewed more carefully to mitigate the risk of regression.
      • Once the change is merged, it is the merger's responsibility to ensure release/XXX is merged into the develop branch.
    • For github workflow changes, use main.
      • Once the change is merged, it is the merger's responsibility to ensure main is merged into both release/XXX and develop, so that the changes also apply to hotfixes, and to current development.
    • For changes to README files, use main.
      • Once the change is merged, it is the merger's responsibility to ensure main is merged into both release/XXX and develop, so that the changes also apply on these branches.

Please remove this section once you confirm you follow its guidance.

Summary

Testing

Update Recommendations

Copy link

github-actions bot commented Dec 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:272a6267af

Copy link

github-actions bot commented Dec 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:272a6267af

Copy link

github-actions bot commented Dec 3, 2024

Benchmark for 272a626

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.4±0.08ms 44.6±0.08ms +0.45%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.02ms 19.6±0.02ms +1.55%
costing::decode_encoded_i8_array_to_manifest_value 40.9±0.04ms 41.6±0.09ms +1.71%
costing::decode_encoded_tuple_array_to_manifest_raw_value 70.6±0.09ms 71.3±0.11ms +0.99%
costing::decode_encoded_tuple_array_to_manifest_value 98.7±0.09ms 98.7±0.16ms 0.00%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.3±0.09µs 32.2±0.17µs -0.31%
costing::decode_encoded_u8_array_to_manifest_value 41.0±0.06ms 41.6±0.06ms +1.46%
costing::decode_rpd_to_manifest_raw_value 14.6±0.05µs 14.6±0.03µs 0.00%
costing::decode_rpd_to_manifest_value 10.7±0.02µs 10.9±0.02µs +1.87%
costing::deserialize_wasm 1205.2±4.96µs 1207.4±3.36µs +0.18%
costing::execute_transaction_creating_big_vec_substates 696.1±5.27ms 698.0±9.28ms +0.27%
costing::execute_transaction_reading_big_vec_substates 576.5±1.17ms 594.3±1.83ms +3.09%
costing::instantiate_flash_loan 939.8±576.85µs 804.7±101.40µs -14.38%
costing::instantiate_radiswap 920.3±713.32µs 1034.5±952.57µs +12.41%
costing::scrypto_malloc 681.0±0.97ms 674.5±1.26ms -0.95%
costing::scrypto_sbor_decode 666.4±2.07ms 668.6±0.71ms +0.33%
costing::scrypto_sha256 589.4±1.38ms 588.5±1.11ms -0.15%
costing::spin_loop_v1 512.2±3.04ms 509.6±1.01ms -0.51%
costing::spin_loop_v2 595.2±3.78ms 624.2±1.96ms +4.87%
costing::validate_sbor_payload 29.1±0.04µs 29.2±0.05µs +0.34%
costing::validate_sbor_payload_bytes 253.6±1.56ns 249.2±0.47ns -1.74%
costing::validate_secp256k1 76.5±0.05µs 76.4±0.04µs -0.13%
costing::validate_wasm 33.6±0.04ms 33.5±0.04ms -0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 314.4±2.21ns 314.8±2.37ns +0.13%
decimal::add/wasmi-call-native 3.0±0.00µs 3.0±0.01µs 0.00%
decimal::div/0 168.6±0.31ns 168.6±0.37ns 0.00%
decimal::from_string/0 156.2±0.13ns 156.4±0.25ns +0.13%
decimal::mul/0 128.3±0.31ns 129.4±0.09ns +0.86%
decimal::mul/rust-native 126.0±0.03ns 128.5±0.04ns +1.98%
decimal::mul/wasmi 19.1±0.15µs 19.6±0.04µs +2.62%
decimal::mul/wasmi-call-native 3.1±0.01µs 3.1±0.01µs 0.00%
decimal::pow/0 591.9±0.30ns 591.6±0.13ns -0.05%
decimal::pow/rust-native 590.2±0.50ns 591.4±0.22ns +0.20%
decimal::pow/wasmi 91.3±0.19µs 90.9±0.16µs -0.44%
decimal::pow/wasmi-call-native 4.9±0.01µs 4.9±0.01µs 0.00%
decimal::root/0 8.0±0.01µs 8.0±0.01µs 0.00%
decimal::sub/0 8.2±0.08ns 8.3±0.01ns +1.22%
decimal::to_string/0 440.9±0.26ns 444.2±0.25ns +0.75%
large_transaction_processing::prepare 2.5±0.00ms 2.5±0.00ms 0.00%
large_transaction_processing::prepare_and_decompile 6.2±0.02ms 6.4±0.02ms +3.23%
large_transaction_processing::prepare_and_decompile_and_recompile 31.1±1.27ms 31.8±0.16ms +2.25%
metadata_validation::validate_urls 4.8±0.01µs 4.7±0.07µs -2.08%
precise_decimal::add/0 8.9±0.02ns 8.6±0.00ns -3.37%
precise_decimal::add/rust-native 10.7±0.01ns 10.6±0.01ns -0.93%
precise_decimal::add/wasmi 402.4±2.05ns 401.2±1.70ns -0.30%
precise_decimal::add/wasmi-call-native 3.9±0.01µs 3.9±0.01µs 0.00%
precise_decimal::div/0 287.6±0.78ns 288.1±0.80ns +0.17%
precise_decimal::from_string/0 201.6±0.20ns 203.9±0.26ns +1.14%
precise_decimal::mul/0 329.7±1.26ns 329.0±0.31ns -0.21%
precise_decimal::mul/rust-native 283.5±0.29ns 284.8±0.49ns +0.46%
precise_decimal::mul/wasmi 49.4±0.06µs 48.0±0.08µs -2.83%
precise_decimal::mul/wasmi-call-native 4.2±0.00µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1725.0±2.14ns 1733.3±10.72ns +0.48%
precise_decimal::pow/rust-native 1381.9±2.40ns 1370.2±1.72ns -0.85%
precise_decimal::pow/wasmi 236.1±0.29µs 231.3±0.46µs -2.03%
precise_decimal::pow/wasmi-call-native 7.6±0.01µs 7.6±0.01µs 0.00%
precise_decimal::root/0 59.1±0.01µs 58.8±0.01µs -0.51%
precise_decimal::sub/0 9.2±0.05ns 9.0±0.05ns -2.17%
precise_decimal::to_string/0 696.8±0.82ns 700.1±1.94ns +0.47%
schema::validate_payload 394.9±0.71µs 382.4±0.85µs -3.17%
transaction::radiswap 4.9±0.02ms 5.0±0.03ms +2.04%
transaction::transfer 1809.9±3.96µs 1816.7±3.34µs +0.38%
transaction_validation::validate_manifest 43.3±0.02µs 43.0±0.10µs -0.69%
transaction_validation::verify_bls_2KB 962.2±7.68µs 972.9±10.94µs +1.11%
transaction_validation::verify_bls_32B 975.2±21.12µs 955.9±6.15µs -1.98%
transaction_validation::verify_ecdsa 74.5±0.06µs 74.3±0.05µs -0.27%
transaction_validation::verify_ed25519 44.3±0.07µs 44.4±0.05µs +0.23%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant