Tweak/sbor types separator

[dhedey]

Summary

A small change which I noticed when making some gnarly types which involved child types containing generic associated types with two values - which needs a comma. This clashed with the comma separator in the type, so I've changed it to a semicolon instead.

Testing

Existing tests pass.

Update Recommendations

While technically a breaking change, I really doubt anyone in the community uses this with two or more types, and if they do, they'll get a pretty obvious compiler error.

[github-actions]

Docker tags
docker.io/radixdlt/private-scrypto-builder:597b9619c7

[github-actions]

Benchmark for 597b961

Click to view benchmark

Test	Base	PR	%
costing::bench_prepare_wasm	45.4±0.33ms	45.7±0.41ms	+0.66%
costing::decode_encoded_i8_array_to_manifest_raw_value	19.8±0.05ms	19.7±0.02ms	-0.51%
costing::decode_encoded_i8_array_to_manifest_value	42.5±0.07ms	43.1±0.06ms	+1.41%
costing::decode_encoded_tuple_array_to_manifest_raw_value	72.3±0.16ms	73.6±0.14ms	+1.80%
costing::decode_encoded_tuple_array_to_manifest_value	121.5±1.20ms	100.5±0.21ms	-17.28%
costing::decode_encoded_u8_array_to_manifest_raw_value	26.4±0.04µs	26.2±0.06µs	-0.76%
costing::decode_encoded_u8_array_to_manifest_value	42.4±0.07ms	43.2±0.05ms	+1.89%
costing::decode_rpd_to_manifest_raw_value	15.0±0.03µs	14.8±0.06µs	-1.33%
costing::decode_rpd_to_manifest_value	11.1±0.04µs	11.1±0.03µs	0.00%
costing::deserialize_wasm	1241.6±7.77µs	1265.6±5.72µs	+1.93%
costing::execute_transaction_creating_big_vec_substates	725.5±10.55ms	717.1±8.61ms	-1.16%
costing::execute_transaction_reading_big_vec_substates	589.7±2.03ms	645.9±0.74ms	+9.53%
costing::instantiate_flash_loan	986.7±1134.97µs	994.7±1264.19µs	+0.81%
costing::instantiate_radiswap	831.9±155.35µs	1061.2±1274.77µs	+27.56%
costing::scrypto_malloc	719.7±72.51ms	713.5±1.70ms	-0.86%
costing::scrypto_sbor_decode	690.1±1.85ms	697.0±2.15ms	+1.00%
costing::scrypto_sha256	592.5±1.89ms	612.8±1.29ms	+3.43%
costing::spin_loop_v1	525.8±1.04ms	522.1±1.21ms	-0.70%
costing::spin_loop_v2	611.0±1.04ms	611.5±4.21ms	+0.08%
costing::validate_sbor_payload	30.3±0.07µs	31.2±0.11µs	+2.97%
costing::validate_sbor_payload_bytes	264.0±0.89ns	264.1±1.96ns	+0.04%
costing::validate_secp256k1	78.0±0.10µs	78.1±0.16µs	+0.13%
costing::validate_wasm	34.3±0.05ms	34.4±0.04ms	+0.29%
decimal::add/0	8.6±0.02ns	8.6±0.02ns	0.00%
decimal::add/rust-native	10.0±0.01ns	10.0±0.02ns	0.00%
decimal::add/wasmi	338.4±2.08ns	314.6±2.93ns	-7.03%
decimal::add/wasmi-call-native	3.0±0.01µs	3.0±0.01µs	0.00%
decimal::div/0	172.5±0.17ns	173.0±0.31ns	+0.29%
decimal::from_string/0	160.6±0.17ns	160.2±0.11ns	-0.25%
decimal::mul/0	131.7±0.35ns	131.8±0.35ns	+0.08%
decimal::mul/rust-native	131.2±0.08ns	128.0±0.23ns	-2.44%
decimal::mul/wasmi	19.6±0.14µs	19.3±0.03µs	-1.53%
decimal::mul/wasmi-call-native	3.1±0.01µs	3.1±0.01µs	0.00%
decimal::pow/0	607.8±0.54ns	606.5±1.09ns	-0.21%
decimal::pow/rust-native	604.2±0.60ns	616.7±0.86ns	+2.07%
decimal::pow/wasmi	93.6±0.49µs	93.0±0.28µs	-0.64%
decimal::pow/wasmi-call-native	4.9±0.01µs	4.8±0.01µs	-2.04%
decimal::root/0	8.3±0.02µs	8.4±0.01µs	+1.20%
decimal::sub/0	8.4±0.11ns	8.4±0.06ns	0.00%
decimal::to_string/0	452.9±1.20ns	459.8±0.51ns	+1.52%
large_transaction_processing::prepare	2.6±0.00ms	2.5±0.00ms	-3.85%
large_transaction_processing::prepare_and_decompile	6.3±0.02ms	6.5±0.03ms	+3.17%
large_transaction_processing::prepare_and_decompile_and_recompile	25.4±0.10ms	33.1±0.19ms	+30.31%
metadata_validation::validate_urls	4.9±0.03µs	5.0±0.03µs	+2.04%
precise_decimal::add/0	9.2±0.02ns	9.2±0.01ns	0.00%
precise_decimal::add/rust-native	10.9±0.01ns	10.9±0.02ns	0.00%
precise_decimal::add/wasmi	436.4±2.17ns	434.1±3.52ns	-0.53%
precise_decimal::add/wasmi-call-native	3.9±0.01µs	3.9±0.01µs	0.00%
precise_decimal::div/0	297.8±1.86ns	294.6±1.26ns	-1.07%
precise_decimal::from_string/0	206.3±0.55ns	206.3±0.22ns	0.00%
precise_decimal::mul/0	349.9±2.87ns	349.4±3.91ns	-0.14%
precise_decimal::mul/rust-native	292.4±1.01ns	290.3±0.46ns	-0.72%
precise_decimal::mul/wasmi	49.6±0.32µs	48.0±0.10µs	-3.23%
precise_decimal::mul/wasmi-call-native	4.3±0.01µs	4.3±0.01µs	0.00%
precise_decimal::pow/0	1798.2±3.93ns	1811.6±5.62ns	+0.75%
precise_decimal::pow/rust-native	1390.2±2.74ns	1386.0±2.36ns	-0.30%
precise_decimal::pow/wasmi	234.4±0.52µs	231.5±0.25µs	-1.24%
precise_decimal::pow/wasmi-call-native	7.8±0.01µs	7.7±0.04µs	-1.28%
precise_decimal::root/0	60.2±0.07µs	59.6±0.06µs	-1.00%
precise_decimal::sub/0	9.5±0.05ns	9.4±0.03ns	-1.05%
precise_decimal::to_string/0	712.5±1.00ns	713.0±2.35ns	+0.07%
schema::validate_payload	393.4±0.96µs	389.6±0.75µs	-0.97%
transaction::radiswap	5.1±0.02ms	5.1±0.04ms	0.00%
transaction::transfer	1840.1±4.58µs	1806.5±10.06µs	-1.83%
transaction_validation::validate_manifest	43.9±0.15µs	44.0±0.21µs	+0.23%
transaction_validation::verify_bls_2KB	1086.8±16.95µs	1064.3±22.32µs	-2.07%
transaction_validation::verify_bls_32B	1065.4±16.36µs	1077.6±36.03µs	+1.15%
transaction_validation::verify_ecdsa	75.9±0.08µs	75.7±0.11µs	-0.26%
transaction_validation::verify_ed25519	43.5±0.09µs	43.2±0.11µs	-0.69%