Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew install to macOS install script #2036

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

azizi-a
Copy link
Contributor

@azizi-a azizi-a commented Dec 5, 2024

Summary

  • Add Homebrew install to macOS install script
  • Fix check for LLVM in PATH variable

Testing

Manually tested on macOS

@azizi-a azizi-a requested a review from iamyulong December 5, 2024 10:07
Copy link

github-actions bot commented Dec 5, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:ae4f8a1a8c

Copy link

github-actions bot commented Dec 5, 2024

Benchmark for ae4f8a1

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.9±0.09ms 44.5±0.21ms -0.89%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.03ms 19.3±0.01ms -1.53%
costing::decode_encoded_i8_array_to_manifest_value 40.9±0.07ms 42.3±0.09ms +3.42%
costing::decode_encoded_tuple_array_to_manifest_raw_value 71.4±0.18ms 72.1±0.19ms +0.98%
costing::decode_encoded_tuple_array_to_manifest_value 98.5±0.40ms 121.3±1.32ms +23.15%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.7±0.07µs 32.4±0.06µs +26.07%
costing::decode_encoded_u8_array_to_manifest_value 40.8±0.04ms 42.5±0.03ms +4.17%
costing::decode_rpd_to_manifest_raw_value 14.6±0.02µs 14.6±0.05µs 0.00%
costing::decode_rpd_to_manifest_value 11.0±0.03µs 10.9±0.03µs -0.91%
costing::deserialize_wasm 1203.6±4.29µs 1229.8±8.36µs +2.18%
costing::execute_transaction_creating_big_vec_substates 682.4±2.43ms 698.4±9.18ms +2.34%
costing::execute_transaction_reading_big_vec_substates 587.8±1.52ms 600.1±2.50ms +2.09%
costing::instantiate_flash_loan 822.7±204.21µs 988.3±951.35µs +20.13%
costing::instantiate_radiswap 940.3±993.39µs 1090.3±1768.37µs +15.95%
costing::scrypto_malloc 668.2±1.11ms 661.0±0.96ms -1.08%
costing::scrypto_sbor_decode 660.6±1.10ms 659.0±0.87ms -0.24%
costing::scrypto_sha256 585.0±1.52ms 583.2±0.61ms -0.31%
costing::spin_loop_v1 509.1±1.09ms 513.7±1.95ms +0.90%
costing::spin_loop_v2 596.5±0.44ms 596.2±3.36ms -0.05%
costing::validate_sbor_payload 29.2±0.07µs 29.5±0.05µs +1.03%
costing::validate_sbor_payload_bytes 254.8±1.42ns 249.9±0.64ns -1.92%
costing::validate_secp256k1 76.5±0.07µs 76.6±0.08µs +0.13%
costing::validate_wasm 33.4±0.03ms 33.5±0.03ms +0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 317.2±1.99ns 321.6±1.78ns +1.39%
decimal::add/wasmi-call-native 2.9±0.00µs 3.0±0.01µs +3.45%
decimal::div/0 168.4±0.30ns 168.1±0.15ns -0.18%
decimal::from_string/0 156.6±0.15ns 158.0±0.19ns +0.89%
decimal::mul/0 127.8±0.23ns 130.0±0.16ns +1.72%
decimal::mul/rust-native 126.8±0.24ns 126.8±0.25ns 0.00%
decimal::mul/wasmi 19.6±0.02µs 19.2±0.03µs -2.04%
decimal::mul/wasmi-call-native 3.1±0.01µs 3.2±0.00µs +3.23%
decimal::pow/0 603.2±0.69ns 592.1±0.33ns -1.84%
decimal::pow/rust-native 589.4±0.67ns 591.4±0.84ns +0.34%
decimal::pow/wasmi 95.8±0.08µs 91.6±0.09µs -4.38%
decimal::pow/wasmi-call-native 5.0±0.02µs 4.9±0.00µs -2.00%
decimal::root/0 8.2±0.01µs 8.1±0.01µs -1.22%
decimal::sub/0 8.2±0.06ns 8.2±0.07ns 0.00%
decimal::to_string/0 443.0±0.25ns 443.6±1.18ns +0.14%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.2±0.02ms 6.2±0.01ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 31.3±0.28ms 29.4±1.49ms -6.07%
metadata_validation::validate_urls 4.7±0.05µs 4.9±0.04µs +4.26%
precise_decimal::add/0 8.9±0.01ns 9.0±0.03ns +1.12%
precise_decimal::add/rust-native 10.7±0.10ns 10.7±0.05ns 0.00%
precise_decimal::add/wasmi 419.4±1.57ns 418.8±1.75ns -0.14%
precise_decimal::add/wasmi-call-native 3.8±0.01µs 3.8±0.01µs 0.00%
precise_decimal::div/0 286.7±0.33ns 295.0±0.62ns +2.90%
precise_decimal::from_string/0 201.5±0.28ns 202.1±0.19ns +0.30%
precise_decimal::mul/0 329.3±0.34ns 332.4±0.28ns +0.94%
precise_decimal::mul/rust-native 287.3±0.14ns 287.1±0.36ns -0.07%
precise_decimal::mul/wasmi 47.5±0.19µs 48.2±0.19µs +1.47%
precise_decimal::mul/wasmi-call-native 4.1±0.00µs 4.2±0.01µs +2.44%
precise_decimal::pow/0 1745.3±2.73ns 1726.4±2.30ns -1.08%
precise_decimal::pow/rust-native 1356.0±1.76ns 1355.7±1.46ns -0.02%
precise_decimal::pow/wasmi 227.8±0.39µs 228.5±0.32µs +0.31%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.5±0.01µs 0.00%
precise_decimal::root/0 57.9±0.02µs 58.0±0.08µs +0.17%
precise_decimal::sub/0 9.2±0.04ns 9.2±0.07ns 0.00%
precise_decimal::to_string/0 691.4±0.20ns 692.7±0.64ns +0.19%
schema::validate_payload 383.9±0.48µs 392.5±0.95µs +2.24%
transaction::radiswap 4.9±0.02ms 4.9±0.02ms 0.00%
transaction::transfer 1787.8±4.37µs 1843.7±3.35µs +3.13%
transaction_validation::validate_manifest 43.1±0.08µs 43.1±0.18µs 0.00%
transaction_validation::verify_bls_2KB 997.6±10.80µs 994.1±9.70µs -0.35%
transaction_validation::verify_bls_32B 969.8±10.63µs 962.8±6.92µs -0.72%
transaction_validation::verify_ecdsa 74.4±0.05µs 74.6±0.06µs +0.27%
transaction_validation::verify_ed25519 47.5±0.08µs 47.4±0.08µs -0.21%

@azizi-a azizi-a requested a review from dhedey December 5, 2024 21:24
@azizi-a azizi-a merged commit 024e11a into release/cuttlefish Dec 6, 2024
31 checks passed
@azizi-a azizi-a deleted the scrypto-install-script-addition branch December 6, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants