Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: use fungible and non-fungible types in template and examples #2037

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

azizi-a
Copy link
Contributor

@azizi-a azizi-a commented Dec 9, 2024

Summary

Update Vault and Bucket types to Fungible and NonFungible versions in examples and template.

Testing

  • Existing tests pass.
  • Manually tested updated Hello blueprint template

Copy link

github-actions bot commented Dec 9, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:c416cf5abe

Copy link

github-actions bot commented Dec 9, 2024

Benchmark for c416cf5

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.4±0.08ms 44.4±0.19ms 0.00%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.02ms 19.9±0.02ms +1.53%
costing::decode_encoded_i8_array_to_manifest_value 40.8±0.05ms 42.3±0.07ms +3.68%
costing::decode_encoded_tuple_array_to_manifest_raw_value 70.5±0.11ms 72.2±0.12ms +2.41%
costing::decode_encoded_tuple_array_to_manifest_value 98.7±0.17ms 98.9±0.11ms +0.20%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.2±0.10µs 32.6±0.12µs +1.24%
costing::decode_encoded_u8_array_to_manifest_value 40.8±0.07ms 42.2±0.05ms +3.43%
costing::decode_rpd_to_manifest_raw_value 14.7±0.04µs 14.5±0.04µs -1.36%
costing::decode_rpd_to_manifest_value 10.9±0.04µs 10.9±0.03µs 0.00%
costing::deserialize_wasm 1208.8±3.82µs 1221.8±4.28µs +1.08%
costing::execute_transaction_creating_big_vec_substates 699.5±3.72ms 703.8±7.70ms +0.61%
costing::execute_transaction_reading_big_vec_substates 597.0±0.62ms 598.5±0.53ms +0.25%
costing::instantiate_flash_loan 883.4±661.29µs 820.1±258.94µs -7.17%
costing::instantiate_radiswap 1081.5±1311.15µs 982.4±1063.09µs -9.16%
costing::scrypto_malloc 648.6±1.74ms 651.1±1.98ms +0.39%
costing::scrypto_sbor_decode 650.6±2.82ms 656.4±5.31ms +0.89%
costing::scrypto_sha256 578.4±1.22ms 579.2±1.38ms +0.14%
costing::spin_loop_v1 511.9±0.33ms 511.6±0.68ms -0.06%
costing::spin_loop_v2 605.3±1.87ms 598.4±1.03ms -1.14%
costing::validate_sbor_payload 30.0±0.06µs 30.7±0.07µs +2.33%
costing::validate_sbor_payload_bytes 250.0±0.79ns 253.3±0.47ns +1.32%
costing::validate_secp256k1 76.5±0.71µs 76.5±0.09µs 0.00%
costing::validate_wasm 33.6±0.03ms 33.5±0.03ms -0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 319.0±3.51ns 320.3±2.92ns +0.41%
decimal::add/wasmi-call-native 3.0±0.00µs 3.0±0.00µs 0.00%
decimal::div/0 169.4±0.33ns 169.4±0.42ns 0.00%
decimal::from_string/0 156.3±0.13ns 157.3±0.13ns +0.64%
decimal::mul/0 128.7±0.09ns 130.1±0.14ns +1.09%
decimal::mul/rust-native 124.9±0.05ns 126.9±0.10ns +1.60%
decimal::mul/wasmi 19.9±0.08µs 20.0±0.08µs +0.50%
decimal::mul/wasmi-call-native 3.1±0.00µs 3.1±0.00µs 0.00%
decimal::pow/0 592.0±0.35ns 592.7±0.44ns +0.12%
decimal::pow/rust-native 590.2±0.50ns 590.6±0.36ns +0.07%
decimal::pow/wasmi 93.8±0.32µs 93.1±0.10µs -0.75%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.8±0.01µs 0.00%
decimal::root/0 8.4±0.01µs 8.1±0.01µs -3.57%
decimal::sub/0 8.3±0.12ns 8.4±0.01ns +1.20%
decimal::to_string/0 446.6±0.53ns 461.4±2.00ns +3.31%
large_transaction_processing::prepare 2.6±0.00ms 2.6±0.00ms 0.00%
large_transaction_processing::prepare_and_decompile 6.1±0.02ms 6.2±0.01ms +1.64%
large_transaction_processing::prepare_and_decompile_and_recompile 29.1±2.17ms 24.9±0.06ms -14.43%
metadata_validation::validate_urls 4.8±0.08µs 4.9±0.06µs +2.08%
precise_decimal::add/0 8.9±0.01ns 8.9±0.03ns 0.00%
precise_decimal::add/rust-native 10.7±0.02ns 10.7±0.05ns 0.00%
precise_decimal::add/wasmi 415.1±2.68ns 415.3±1.79ns +0.05%
precise_decimal::add/wasmi-call-native 3.9±0.01µs 3.8±0.01µs -2.56%
precise_decimal::div/0 287.0±0.26ns 312.2±1.08ns +8.78%
precise_decimal::from_string/0 201.7±0.15ns 202.3±0.13ns +0.30%
precise_decimal::mul/0 330.3±0.52ns 333.1±0.49ns +0.85%
precise_decimal::mul/rust-native 286.4±1.03ns 294.4±2.14ns +2.79%
precise_decimal::mul/wasmi 48.6±0.07µs 48.9±0.08µs +0.62%
precise_decimal::mul/wasmi-call-native 4.2±0.01µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1731.0±1.59ns 1731.0±3.17ns 0.00%
precise_decimal::pow/rust-native 1385.3±3.89ns 1381.2±3.16ns -0.30%
precise_decimal::pow/wasmi 232.0±0.89µs 234.2±0.56µs +0.95%
precise_decimal::pow/wasmi-call-native 7.6±0.02µs 7.6±0.01µs 0.00%
precise_decimal::root/0 57.5±0.02µs 57.9±0.02µs +0.70%
precise_decimal::sub/0 9.2±0.02ns 9.2±0.08ns 0.00%
precise_decimal::to_string/0 695.3±0.54ns 697.6±0.76ns +0.33%
schema::validate_payload 379.8±0.50µs 383.0±0.45µs +0.84%
transaction::radiswap 5.1±0.03ms 5.0±0.02ms -1.96%
transaction::transfer 1816.2±3.69µs 1830.4±3.06µs +0.78%
transaction_validation::validate_manifest 43.1±0.18µs 43.2±0.02µs +0.23%
transaction_validation::verify_bls_2KB 994.1±16.07µs 952.5±5.55µs -4.18%
transaction_validation::verify_bls_32B 987.0±13.79µs 968.8±20.60µs -1.84%
transaction_validation::verify_ecdsa 74.5±0.25µs 74.6±0.07µs +0.13%
transaction_validation::verify_ed25519 42.2±0.09µs 46.7±0.06µs +10.66%

@azizi-a azizi-a merged commit 7d7ab4e into release/cuttlefish Dec 10, 2024
31 checks passed
@azizi-a azizi-a deleted the example-bucket-and-vault-types branch December 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants