Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recovery proposal manifest sbor #2038

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

0xOmarA
Copy link
Member

@0xOmarA 0xOmarA commented Dec 9, 2024

No description provided.

Copy link

github-actions bot commented Dec 9, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:8fc9072d2a

Copy link

github-actions bot commented Dec 9, 2024

Benchmark for 8fc9072

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.6±0.06ms 44.4±0.07ms -0.45%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.02ms 19.3±0.02ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 41.8±0.06ms 42.8±0.06ms +2.39%
costing::decode_encoded_tuple_array_to_manifest_raw_value 70.6±0.22ms 72.1±0.09ms +2.12%
costing::decode_encoded_tuple_array_to_manifest_value 99.2±0.14ms 105.1±0.32ms +5.95%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.2±0.09µs 25.8±0.06µs -19.88%
costing::decode_encoded_u8_array_to_manifest_value 41.7±0.08ms 42.6±0.06ms +2.16%
costing::decode_rpd_to_manifest_raw_value 14.6±0.03µs 14.5±0.03µs -0.68%
costing::decode_rpd_to_manifest_value 10.9±0.02µs 10.9±0.02µs 0.00%
costing::deserialize_wasm 1214.5±2.48µs 1216.8±5.80µs +0.19%
costing::execute_transaction_creating_big_vec_substates 711.4±9.60ms 707.5±8.72ms -0.55%
costing::execute_transaction_reading_big_vec_substates 616.5±1.34ms 577.9±1.21ms -6.26%
costing::instantiate_flash_loan 916.8±823.66µs 910.0±478.56µs -0.74%
costing::instantiate_radiswap 951.7±971.79µs 814.2±73.72µs -14.45%
costing::scrypto_malloc 655.8±2.48ms 673.9±1.53ms +2.76%
costing::scrypto_sbor_decode 655.4±1.07ms 658.4±1.78ms +0.46%
costing::scrypto_sha256 580.8±1.24ms 582.9±1.78ms +0.36%
costing::spin_loop_v1 518.8±1.63ms 515.7±9.95ms -0.60%
costing::spin_loop_v2 601.6±3.84ms 596.2±0.81ms -0.90%
costing::validate_sbor_payload 29.4±0.05µs 30.1±0.05µs +2.38%
costing::validate_sbor_payload_bytes 275.0±2.40ns 263.7±2.02ns -4.11%
costing::validate_secp256k1 76.4±0.05µs 76.6±0.14µs +0.26%
costing::validate_wasm 33.5±0.04ms 33.4±0.03ms -0.30%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 333.5±4.90ns 318.5±1.74ns -4.50%
decimal::add/wasmi-call-native 2.9±0.01µs 2.8±0.01µs -3.45%
decimal::div/0 166.8±0.17ns 174.5±0.25ns +4.62%
decimal::from_string/0 157.2±0.18ns 166.6±0.23ns +5.98%
decimal::mul/0 126.6±0.04ns 129.7±0.17ns +2.45%
decimal::mul/rust-native 128.6±0.06ns 128.6±0.09ns 0.00%
decimal::mul/wasmi 21.3±0.14µs 19.6±0.08µs -7.98%
decimal::mul/wasmi-call-native 3.2±0.01µs 3.0±0.01µs -6.25%
decimal::pow/0 592.1±0.18ns 591.1±0.23ns -0.17%
decimal::pow/rust-native 590.2±0.30ns 590.7±0.42ns +0.08%
decimal::pow/wasmi 91.6±0.28µs 92.2±0.14µs +0.66%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.7±0.01µs -2.08%
decimal::root/0 8.0±0.01µs 8.2±0.01µs +2.50%
decimal::sub/0 8.4±0.01ns 8.4±0.01ns 0.00%
decimal::to_string/0 446.2±0.65ns 450.6±2.85ns +0.99%
large_transaction_processing::prepare 2.5±0.00ms 2.6±0.00ms +4.00%
large_transaction_processing::prepare_and_decompile 6.2±0.01ms 6.1±0.02ms -1.61%
large_transaction_processing::prepare_and_decompile_and_recompile 31.6±0.13ms 28.7±3.38ms -9.18%
metadata_validation::validate_urls 5.0±0.05µs 4.7±0.01µs -6.00%
precise_decimal::add/0 8.8±0.16ns 8.9±0.01ns +1.14%
precise_decimal::add/rust-native 10.8±0.30ns 10.7±0.28ns -0.93%
precise_decimal::add/wasmi 423.8±4.33ns 422.4±3.63ns -0.33%
precise_decimal::add/wasmi-call-native 3.8±0.00µs 3.8±0.01µs 0.00%
precise_decimal::div/0 296.2±1.89ns 324.3±1.76ns +9.49%
precise_decimal::from_string/0 201.2±0.32ns 204.7±0.25ns +1.74%
precise_decimal::mul/0 336.9±1.70ns 341.8±2.20ns +1.45%
precise_decimal::mul/rust-native 288.0±1.63ns 286.3±0.42ns -0.59%
precise_decimal::mul/wasmi 48.0±0.23µs 48.1±0.11µs +0.21%
precise_decimal::mul/wasmi-call-native 4.2±0.00µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1778.6±2.91ns 1766.8±4.58ns -0.66%
precise_decimal::pow/rust-native 1355.6±1.06ns 1355.6±0.75ns 0.00%
precise_decimal::pow/wasmi 226.9±0.81µs 230.3±0.25µs +1.50%
precise_decimal::pow/wasmi-call-native 7.5±0.01µs 7.5±0.01µs 0.00%
precise_decimal::root/0 58.7±0.01µs 58.0±0.03µs -1.19%
precise_decimal::sub/0 9.0±0.13ns 9.1±0.04ns +1.11%
precise_decimal::to_string/0 691.5±0.74ns 716.7±1.09ns +3.64%
schema::validate_payload 387.8±0.48µs 392.2±0.58µs +1.13%
transaction::radiswap 5.0±0.02ms 5.0±0.03ms 0.00%
transaction::transfer 1785.9±10.73µs 1854.4±4.28µs +3.84%
transaction_validation::validate_manifest 43.1±0.07µs 43.2±0.07µs +0.23%
transaction_validation::verify_bls_2KB 956.5±8.72µs 965.3±8.83µs +0.92%
transaction_validation::verify_bls_32B 957.6±11.79µs 982.6±20.15µs +2.61%
transaction_validation::verify_ecdsa 74.7±0.10µs 74.4±0.08µs -0.40%
transaction_validation::verify_ed25519 47.5±0.07µs 42.3±0.12µs -10.95%

Copy link

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xOmarA 0xOmarA merged commit c619e4b into release/cuttlefish Dec 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants