[ABW-3982] Check asset deposit rules before transferring on Delete Ac…

…count (#272)

* models

* updates

* fixes and set up to filter non transferable

* final implementation

* version bump

* renames

* missing test

* rename to Outcome

* more tests to increase coverage

* updates after feedback

* ignore items with zero amount

crates/sargon-uniffi/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "sargon-uniffi"
 # Don't forget to update version in crates/sargon/Cargo.toml
-version = "1.1.55"
+version = "1.1.56"
 edition = "2021"
 build = "build.rs"
 

crates/sargon-uniffi/src/core/error/common_error.rs

@@ -732,14 +732,11 @@ pub enum CommonError {
     #[error("Subintent has already expired")]
     SubintentExpired = 10206,
 
-    #[error("Unexpected collection item aggregation")]
-    UnexpectedCollectionItemAggregation = 10207,
-
     #[error("Unable to make {amount} transfers in one single transaction")]
-    MaxTransfersPerTransactionReached { amount: u64 } = 10208,
+    MaxTransfersPerTransactionReached { amount: u64 } = 10207,
 
     #[error("Transaction Manifest class is reserved: {class}")]
-    ReservedManifestClass { class: DetailedManifestClass } = 10209,
+    ReservedManifestClass { class: DetailedManifestClass } = 10208,
 }
 
 #[uniffi::export]

crates/sargon-uniffi/src/system/sargon_os/delete_account/mod.rs

@@ -0,0 +1,5 @@
+mod sargon_os_delete_account;
+mod support;
+
+pub use sargon_os_delete_account::*;
+pub use support::*;

crates/sargon-uniffi/src/system/sargon_os/sargon_os_delete_account.rs → crates/sargon-uniffi/src/system/sargon_os/delete_account/sargon_os_delete_account.rs

@@ -12,7 +12,7 @@ impl SargonOS {
         &self,
         account_address: AccountAddress,
         recipient_account_address: Option<AccountAddress>,
-    ) -> Result<TransactionManifest> {
+    ) -> Result<CreateDeleteAccountManifestOutcome> {
         self.wrapped
             .create_delete_account_manifest(
                 account_address.into_internal(),

crates/sargon-uniffi/src/system/sargon_os/delete_account/support/mod.rs

@@ -0,0 +1,3 @@
+mod outcome;
+
+pub use outcome::*;

crates/sargon-uniffi/src/system/sargon_os/delete_account/support/outcome.rs

@@ -0,0 +1,8 @@
+use crate::prelude::*;
+use sargon::CreateDeleteAccountManifestOutcome as InternalCreateDeleteAccountManifestOutcome;
+
+#[derive(Clone, PartialEq, Eq, InternalConversion, uniffi::Record)]
+pub struct CreateDeleteAccountManifestOutcome {
+    pub manifest: TransactionManifest,
+    pub non_transferable_resources: Vec<ResourceAddress>,
+}

crates/sargon-uniffi/src/system/sargon_os/mod.rs

@@ -1,15 +1,16 @@
+mod delete_account;
 mod pre_authorization;
 mod profile_state_holder;
 mod sargon_os;
 mod sargon_os_accounts;
-mod sargon_os_delete_account;
 mod sargon_os_factors;
 mod sargon_os_gateway;
 mod sargon_os_profile;
 mod sargon_os_security_structures;
 mod sargon_os_sync_accounts;
 mod transactions;
 
+pub use delete_account::*;
 pub use profile_state_holder::*;
 pub use sargon_os::*;
 pub use sargon_os_accounts::*;

crates/sargon/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "sargon"
 # Don't forget to update version in crates/sargon-uniffi/Cargo.toml
-version = "1.1.55"
+version = "1.1.56"
 edition = "2021"
 build = "build.rs"