fix swift tests

radixdlt · Dec 19, 2024 · e8d16d6 · e8d16d6
1 parent cd456d2
commit e8d16d6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/apple/Tests/TestCases/Profile/MFA/SecurityShieldsBuilderTests.swift b/apple/Tests/TestCases/Profile/MFA/SecurityShieldsBuilderTests.swift
@@ -104,6 +104,9 @@ struct ShieldTests {
 
 		#expect(builder.validate() == .ConfirmationRoleMustHaveAtLeastOneFactor)
 		builder.addFactorSourceToConfirmationOverride(factorSourceId: .sampleArculus)
+
+		builder.setAuthenticationSigningFactor(new: .sampleDevice)
+
 		#expect(builder.validate() == nil)
 		#expect((try? builder.build()) != nil)
 	}
@@ -173,6 +176,8 @@ struct ShieldTests {
 		builder.addFactorSourceToRecoveryOverride(factorSourceId: .sampleArculus)
 		builder.addFactorSourceToConfirmationOverride(factorSourceId: .sampleArculusOther)
 
+		builder.setAuthenticationSigningFactor(new: .sampleDevice)
+
 		let shield = try! builder.build()
 
 		#expect(shield.matrixOfFactors.primaryRole.overrideFactors.isEmpty)
@@ -205,6 +210,8 @@ struct ShieldTests {
 		builder.removeFactorFromPrimary(factorSourceId: .sampleArculusOther)
 		builder.removeFactorFromRecovery(factorSourceId: .sampleLedgerOther)
 
+		builder.setAuthenticationSigningFactor(new: .sampleDevice)
+
 		// Validate
 		#expect(builder.validate() == nil)
 

diff --git a/crates/sargon/src/factor_instances_provider/provider/factor_instances_provider.rs b/crates/sargon/src/factor_instances_provider/provider/factor_instances_provider.rs
@@ -417,7 +417,6 @@ impl FactorInstancesProvider {
                 Ok((derivation_preset, per_factor_paths))
             })
             .collect::<Result<
-                // IndexMap<FactorSourceIDFromHash, IndexSet<DerivationPath>>,
                 IndexMap<
                     DerivationPreset,
                     IndexMap<FactorSourceIDFromHash, IndexSet<DerivationPath>>,

diff --git a/crates/sargon/src/profile/mfa/security_structures/matrices/matrix_of_factor_instances.rs b/crates/sargon/src/profile/mfa/security_structures/matrices/matrix_of_factor_instances.rs
@@ -239,7 +239,6 @@ impl SecurityStructureOfFactorInstances {
             let _ = existing.shift_remove(&instance); // don't forget to consume it!
             Ok(instance)
         } else {
-            println!("👨‍🔬 SSFI ❌ get_mut failed => MissingRolaKeyForSecurityStructureOfFactorInstances ❌");
             Err(CommonError::MissingRolaKeyForSecurityStructureOfFactorInstances)
         }?;