-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction Analysis allow unknown accounts #307
Conversation
RoleKind::Primary, | ||
); | ||
|
||
assert!(matches!(result, Err(CommonError::UnknownAccount))); | ||
assert!(matches!(result, Err(CommonError::UnknownPersona))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still invalid for unknown persona. We might change it in the future, but feels strange for a manifest to contain an unknown persona.
.filter_map(|a| a.ok()) | ||
.collect::<Vec<_>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=====================================
Coverage 93.3% 93.3%
=====================================
Files 1109 1109
Lines 23547 23548 +1
Branches 79 79
=====================================
+ Hits 21974 21975 +1
Misses 1558 1558
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fed6826
to
e7580ad
Compare
crates/sargon/src/system/sargon_os/transactions/sargon_os_transaction_analysis.rs
Outdated
Show resolved
Hide resolved
c544fe3
to
a3ed621
Compare
This reverts commit 0d9f205.
Allow transaction manifests which contain unknown accounts which to require signatures. The Wallet should not reject such transactions.
References:
The new behaviour was introduced with Sargon, and we reject the manifest at the moment we try to extract the public keys to be sent to the GW. Old implementation, did allow for unknown accounts, see iOS for reference.