Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE ME] Split Sargon into many crates #318

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+15,537 −6,793

Split Factors module into separate crate (and some more) (#324)

81aef4b
Select commit
Loading
Failed to load commit list.
Open

[MERGE ME] Split Sargon into many crates #318

Split Factors module into separate crate (and some more) (#324)
81aef4b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 30, 2024 in 1s

93.1% (-0.2%) compared to e18bd66

View this Pull Request on Codecov

93.1% (-0.2%) compared to e18bd66

Details

Codecov Report

Attention: Patch coverage is 96.51163% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.1%. Comparing base (e18bd66) to head (81aef4b).

Files with missing lines Patch % Lines
.../test_keys_collector/test_derivation_interactor.rs 87.5% 3 Missing ⚠️
crates/sargon-core/src/has_sample_values.rs 83.3% 2 Missing ⚠️
...argon-factors/src/factor_source_id_from_address.rs 75.0% 2 Missing ⚠️
...s/identified-vec-of/src/identified_vec_of_serde.rs 0.0% 1 Missing ⚠️
...s/sargon-addresses/src/address/wrap_ret_address.rs 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #318     +/-   ##
=======================================
- Coverage   93.3%   93.1%   -0.2%     
=======================================
  Files       1111    1122     +11     
  Lines      24248   24781    +533     
  Branches      79      79             
=======================================
+ Hits       22637   23091    +454     
- Misses      1596    1675     +79     
  Partials      15      15
Files with missing lines Coverage Δ
...thods/Profile/CAP26EntityKind+Wrap+Functions.swift 100.0% <100.0%> (ø)
...ied/Crypto/Derivation/AccountPath+Swiftified.swift 100.0% <100.0%> (ø)
...ed/Crypto/Derivation/IdentityPath+Swiftified.swift 100.0% <100.0%> (ø)
...wiftified/Profile/CAP26EntityKind+Swiftified.swift 100.0% <100.0%> (ø)
...-vec-of/src/decl_identified_vec_of_with_samples.rs 100.0% <100.0%> (ø)
crates/identified-vec-of/src/identified_vec_of.rs 86.6% <ø> (ø)
...fied-vec-of/src/identified_vec_of_display_debug.rs 100.0% <ø> (ø)
...dentified-vec-of/src/identified_vec_of_iterator.rs 100.0% <ø> (ø)
.../identified-vec-of/src/identified_vec_of_modify.rs 86.6% <ø> (ø)
...s/identified-vec-of/src/identified_vec_of_query.rs 100.0% <ø> (ø)
... and 188 more

... and 54 files with indirect coverage changes

View more details on Codecov