Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signing interactor's IO with per factor models #333

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

micbakos-rdx
Copy link
Contributor

@micbakos-rdx micbakos-rdx commented Jan 8, 2025

The interactor supports output per factor. SignResponse is now the output of the interactor and is a map between factors and FactorOutcomes.

  • Uniffi structs are updated accordingly.
  • Poly sign is supported but opted out.
  • Kotlin exposes a generic Signable almost just like rust which maps to internal concrete types when in need to return the result to the interactor.
  • Checking the integration on host.
  • Update version

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 88.41808% with 41 lines in your changes missing coverage. Please review.

Project coverage is 92.01%. Comparing base (1292838) to head (8b9a6e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../app/signing/src/collector/signatures_collector.rs 54.38% 26 Missing ⚠️
...gning-traits/src/host_interaction/sign_response.rs 79.16% 5 Missing ⚠️
...es/core/has-sample-values/src/has_sample_values.rs 0.00% 4 Missing ⚠️
...ning-traits/src/host_interaction/factor_outcome.rs 92.10% 3 Missing ⚠️
...s/app/signing-traits/src/types/neglected_factor.rs 0.00% 2 Missing ⚠️
crates/app/signing/src/petition_types/petitions.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #333    +/-   ##
========================================
  Coverage   92.01%   92.01%            
========================================
  Files        1137     1152    +15     
  Lines       25446    25675   +229     
  Branches       79       85     +6     
========================================
+ Hits        23413    23626   +213     
- Misses       2018     2034    +16     
  Partials       15       15            
Flag Coverage Δ
kotlin 97.56% <100.00%> (+0.37%) ⬆️
rust 91.37% <76.43%> (-0.12%) ⬇️
swift 93.74% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micbakos-rdx micbakos-rdx added Coverage OK ☂️ ✅ False Negatives in Code Coverage by Tarpaulin Rust 🦀 Changes in Rust Sargon Kotlin 🤖 Changes in Kotlin Sargon UniFFI 🦄 Changes in UniFFI exported APIs labels Jan 8, 2025
@micbakos-rdx micbakos-rdx marked this pull request as ready for review January 8, 2025 13:58
@micbakos-rdx micbakos-rdx force-pushed the micbakos/ABW-4027-update-signing-io branch from 3b556b6 to e2f6591 Compare January 8, 2025 15:14
@micbakos-rdx micbakos-rdx force-pushed the micbakos/ABW-4027-update-signing-io branch from e2f6591 to 610146e Compare January 9, 2025 08:17
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbakos-rdx micbakos-rdx merged commit 7ac2d4a into main Jan 9, 2025
13 checks passed
@micbakos-rdx micbakos-rdx deleted the micbakos/ABW-4027-update-signing-io branch January 9, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coverage OK ☂️ ✅ False Negatives in Code Coverage by Tarpaulin Kotlin 🤖 Changes in Kotlin Sargon Rust 🦀 Changes in Rust Sargon UniFFI 🦄 Changes in UniFFI exported APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants