Single folder for fixtures, remove almost all build scripts, make file #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
CyonAlexRDX
changed the title
CyonAlexRDX
requested review from
matiasbzurovski,
GhenadieVP,
micbakos-rdx,
sergiupuhalschi-rdx,
danvleju-rdx and
giannis-rdx
CyonAlexRDX
commented
Jan 8, 2025
| @@ -241,6 +240,15 @@ mod tests { | |||
|
|
|||
| use base64::engine::general_purpose::URL_SAFE_NO_PAD; | |||
|
|
|||
| #[test] | |||
| fn aaaaparse_url_into_request() { | |||
GhenadieVP
approved these changes
Jan 8, 2025
makefile
Outdated
There was a problem hiding this comment.
Could add also build_ios
CyonAlexRDX
commented
Jan 8, 2025
| env!("FIXTURES_VECTOR"), | ||
| "rola_challenge_payload_hash_vectors.json" | ||
| )); | ||
| let json = fixture_vector!("rola_challenge_payload_hash_vectors"); |
There was a problem hiding this comment.
Way nicer right?!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 427 427
Lines 4688 4688
Branches 79 79
=======================================
Hits 4422 4422
Misses 251 251
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
patchversion for all crates, one variant which git commits and one which does notmake bumpormake bump_and_committo bumpROOT/fixtures.cargo/config.tomlwhich sets an importantCARGO_WORKSPACE_DIRvar which can be used from anywhere.preludewhich hasmacro_rulesfor fixtures filespreludeinclude_str!(concat!(env!("FIXTURE...))to use the new fixtures macro