Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in retrieveFileList() #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Botono
Copy link

@Botono Botono commented Nov 22, 2021

I have been getting a fatal error: sync: unlock of unlocked mutex when using the package in my setup, although I have not been able to reproduce it in isolation yet. However, implementing this change fixes the panic.

Unlocking the mutex inside of a locking method introduces a race condition. This change creates private methods that do the operations of the Remove() and RemoveRecursive() methods, but without the mutex locks. This allows retrieveFileList() to call them without unlocking the mutex first.

Remove() and RemoveRecursive() are then updated to call the private methods instead of doing the processing themselves.

… the mutex, allowing the retrieveFileList method use a single lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant