Add live data to wallet sync details #469
Conversation
There was a problem hiding this comment.
There seems to be spacing between trailing and leading amount text, you should check how send page confirmation window implements amount texts https://github.com/raedahgroup/godcr/blob/0dc5f3cac669f276f1244f061976bdcf17212380/fyne/pages/handler/sendpagehandler/confirmationwindow.go#L47
We should add padding
Overview text should be titled
All header text should be titled.
Amount table contents should be right aligned
table contents should be centered
Kindly clarify what you mean by titled. |
First character should be upper case |
moved update logic to handlers added more live data and cleaned up overview handler
moved sync status calls to separate goroutine removed block sync status when sync is complete fix balance bug and add dynamic sync status
clean up UI and handler code add indentation to status text and padding to page
fix wallet details bug added delay for table implementation fix overview render delay bug
add padding to wallet boxes and fix on sync button fix balance spacing and transactions alignment add capitalization to overview and transactions headers
oshorefueled
force-pushed
the
overview-447
branch
from
435d039 to
6d0c6cf
Compare
|
|
There was a problem hiding this comment.
UI Changes
-
We need to remove horizontal scroll, confirmed/pending text needs to be labeled
-
Bottom padding doesn't seem right, can we add decred logo at the top of overview text?
-
Table looks off, can we instead start with Direction Icon, Date, Amount, Fee, Status ("Left Aligned") check below image for reference and also I guess Direction is same thing as # on the table
- When sync completes and objects are hidden, the window size isn't calibrated and table centered
- When wallet is disconnected sync steps and wallet info bar are shown
Color when wallet is synced, syncing and not synced seems off
Texts in bordered wallet info can be enlarged so as to be clear and border can be padded
- while syncing it doesn't report how many minutes left for sync to be done but instead there's a timer and also the scroller housing wallet info moves back to the starting if scrolled
There was a problem hiding this comment.
When I created a new wallet and tried canceling sync, the window stalls and I have to force close the app also, progress bar isn't updated while syncing
sync/waiting for sync seems not to be accurate
show/hide details button is missing
Progress bar should be updated for all steps
Lastly can we do away with the goroutines used in overview.go? I still see no reason for this, we initialize all dynamic objects then pass them to the txnotifier which should be capable of handling all dynamic objects
| Synced bool | ||
| Syncing bool | ||
| SyncProgress float64 | ||
| ConnectedPeers int32 | ||
| Steps int32 | ||
| hideSyncDetails bool | ||
|
|
||
| Container fyne.CanvasObject | ||
| TransactionsContainer *fyne.Container | ||
| Balance []*canvas.Text | ||
| Transactions []dcrlibwallet.Transaction | ||
| PageBoxes fyne.CanvasObject | ||
| SyncStatusWidget *canvas.Text | ||
| TimeLeftWidget *widget.Label | ||
| BlockHeightTime *widget.Label | ||
| ProgressBar *widget.ProgressBar | ||
| BlockStatus *fyne.Container | ||
| BlockStatusSynced fyne.CanvasObject | ||
| BlockStatusSyncing fyne.CanvasObject | ||
| Table *widgets.Table | ||
| TableHeader *widget.Box | ||
| ConnectedPeersWidget *widget.Label | ||
| SyncStepWidget *widget.Label | ||
| BlockHeadersWidget *widget.Label | ||
| WalletSyncInfo *fyne.Container | ||
| Scroll *widget.ScrollContainer | ||
| SyncButton *widget.Button | ||
|
|
||
| StepsChannel chan int32 |
There was a problem hiding this comment.
Do we need to make all variables exportable? can we only make variables that are dynamic exportable? we should try our best to bring about encapsulation of variables and functions/methods
This are the variables that are needed
Sync label
Table widget
Time left label
Last time of block fetched
Balance label (we just pass the *fyne.Container object and then if we need to dynamically change this we can pass the values to the struct field "Objects" to dynamically change the balance label)
Button to enable/disable syncing
Steps label and Header/address discovery label
Connected peer count label
Block count label
contents in bordered wallet info (synced, block header fetched and syncing progress label) we can pass them as an array of *canvas.Text
You only need to make the functions/methods that initializes overview page and that are passed to txnotifier.go exportable in the handler package so that all other helper functions/methods in handler package are private to pages package bringing about encapsulation also, functions to be passed to txnotifier can be moved to the handler package.
| func (handler *OverviewHandler) SyncTrigger(wallet *dcrlibwallet.MultiWallet) { | ||
| var notifyTitle, notifyMessage string | ||
| synced, syncing := wallet.IsSynced(), wallet.IsSyncing() | ||
| if wallet.ConnectedPeers() > 0 && (synced || syncing) { |
There was a problem hiding this comment.
What if there's no internet connection and connected peers is 0? I really dont think this conditions are necessary, only if wallet.IsSyncing or not should do
This PR closes #447. It adds live wallet sync details to the overview page.