chore: refactor code to meet pylint style guidelines. WIP #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSee Review Map:Review in an interactive map View more CodeSee Maps Legend |
rafaeelaudibert
requested changes
Oct 31, 2021
There was a problem hiding this comment.
This looks incredible @chtnnh! Thank you so much for contributing. I've left a review below, with some questions and suggested changes.
I think we could leave the CI for a next PR, just so that this PR doesn't get even bigger. What are your thoughts?
Comment on lines
-15
to
+24
| self.message = message | ||
| BadRequest.message = message |
There was a problem hiding this comment.
Why do we need this change? We could do it differently, though, calling super.__init__(message)
There was a problem hiding this comment.
Linter threw an error I didn't fully understand. But this made it go away 😆
LMK if this is unacceptable
Co-authored-by: Rafael Baldasso Audibert <[email protected]>
Co-authored-by: Rafael Baldasso Audibert <[email protected]>
Co-authored-by: Rafael Baldasso Audibert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34
Sorry, I may have jumped the gun on this @rafaeelaudibert but it was really bugging me.
Also, might need your help with setting up the GitHub CI to check for pylint errors