Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper condition checks to the interation with the blockchain (using Raiden proxies) #315

Open
hackaugusto opened this issue Sep 11, 2019 · 0 comments
Labels
Feature request A request for a new SP feature Logging

Comments

@hackaugusto
Copy link
Contributor

Description

Scenario failures messages are useless, example:

scenario_player.exceptions.legacy.ScenarioTxError: Transaction 0x4f26e8b4d9cbeb06fe339ff85f6f4140a8e63be4d76475975f9bd3e104cb1915 failed.

Expected Behavior

The asserts/requires of a smart contract should be verified before and after a transaction is sent, and a proper error message should be given. The above error message is not useful for a user and it takes a long time to debug.

Please consider using the proxies from the raiden package, a lot of time was spent making sure these messages are useful, and that all cases are properly covered. e.g. The above error is likely handled by this code

@hackaugusto hackaugusto added the bug Something isn't working label Sep 11, 2019
@christianbrb christianbrb added Feature request A request for a new SP feature Logging and removed bug Something isn't working labels Sep 23, 2019
@christianbrb christianbrb added this to the Product Backlog milestone Oct 30, 2019
@christianbrb christianbrb changed the title Add proper condition checks to the interation with the blockchain Add proper condition checks to the interation with the blockchain (using Raiden proxies) Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request A request for a new SP feature Logging
Projects
None yet
Development

No branches or pull requests

2 participants