RPC Service - Allow concurrent Scenario Runs #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #201 +/- ##
======================================
Coverage ? 58.41%
======================================
Files ? 70
Lines ? 3263
Branches ? 0
======================================
Hits ? 1906
Misses ? 1357
Partials ? 0
Continue to review full report at Codecov.
|
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
from
0797435
to
30bb58c
Compare
ghost
suggested changes
Aug 14, 2019
ghost
previously requested changes
Aug 14, 2019
There was a problem hiding this comment.
I would probably look into using a ready-made library, maybe https://github.com/thesharp/daemonize
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
from
fb76663
to
f75a53c
Compare
Done. Thanks for the review! |
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
3 times, most recently
from
4619a75
to
d838355
Compare
deepbrook
dismissed
ghost
’s stale review
Implemented requested changes, switched to third-party daemon lib.
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
3 times, most recently
from
2254f6a
to
b751a56
Compare
deepbrook
force-pushed
the
dev
branch
2 times, most recently
from
cc7effe
to
449b12f
Compare
Master at 0.3.5
Adds the following: - daemonie(), start_daemon(), stop_daemon() utility funcs. - RPC service app constructor and service daemon. - SPaaS Service Stack daemon - Entrypoints for the SPaaS stack and the SPaaS RPC daemons.
added 20 commits
August 23, 2019 11:40
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
from
b751a56
to
f7c6f65
Compare
deepbrook
force-pushed
the
SPaaS-Transaction-Service
branch
from
50d9911
to
135d8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #62 and closes #208
Allows running multiple scenarios concurrently, when passing the--spaas-no-teardownflag to the SP cli command.This no longer run dameonized processes, but instead creates
systemduser-land services.Before running the SP, installation is required:
Which creates service files and enables them for the user.
Removing them is simple as well, and takes care of stopping and disabling them first: