Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Service - Allow concurrent Scenario Runs #201

Closed
wants to merge 39 commits into from

Conversation

deepbrook
Copy link

@deepbrook deepbrook commented Aug 9, 2019

Finishes #62 and closes #208

Allows running multiple scenarios concurrently, when passing the --spaas-no-teardown flag to the SP cli command.

This no longer run dameonized processes, but instead creates systemd user-land services.

Before running the SP, installation is required:

spaas install

Which creates service files and enables them for the user.

Removing them is simple as well, and takes care of stopping and disabling them first:

spaas remove

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@60b3598). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #201   +/-   ##
======================================
  Coverage       ?   58.41%           
======================================
  Files          ?       70           
  Lines          ?     3263           
  Branches       ?        0           
======================================
  Hits           ?     1906           
  Misses         ?     1357           
  Partials       ?        0
Impacted Files Coverage Δ
scenario_player/main.py 51.38% <ø> (ø)
scenario_player/services/utils/cli/interface.py 0% <0%> (ø)
scenario_player/services/common/app.py 0% <0%> (ø)
scenario_player/services/utils/cli/runner.py 0% <0%> (ø)
scenario_player/services/utils/cli/parsers.py 0% <0%> (ø)
scenario_player/services/utils/cli/constants.py 100% <100%> (ø)
scenario_player/services/rpc/app.py 100% <100%> (ø)
scenario_player/utils/interface.py 78.75% <100%> (ø)
scenario_player/runner.py 28.43% <100%> (ø)
scenario_player/utils/token.py 92.61% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b3598...50d9911. Read the comment docs.

scenario_player/services/utils/factories.py Outdated Show resolved Hide resolved
scenario_player/services/utils/factories.py Outdated Show resolved Hide resolved
scenario_player/services/utils/factories.py Outdated Show resolved Hide resolved
ghost
ghost previously requested changes Aug 14, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably look into using a ready-made library, maybe https://github.com/thesharp/daemonize

@deepbrook
Copy link
Author

I would probably look into using a ready-made library, maybe https://github.com/thesharp/daemonize

Done. Thanks for the review!

@deepbrook deepbrook force-pushed the SPaaS-Transaction-Service branch 3 times, most recently from 4619a75 to d838355 Compare August 20, 2019 06:22
@deepbrook deepbrook dismissed ghost ’s stale review August 20, 2019 06:24

Implemented requested changes, switched to third-party daemon lib.

@deepbrook deepbrook removed the request for review from ulope August 20, 2019 06:24
@deepbrook deepbrook force-pushed the SPaaS-Transaction-Service branch 3 times, most recently from 2254f6a to b751a56 Compare August 22, 2019 08:49
DevOpsBot and others added 11 commits August 22, 2019 13:21
Adds the following:

- daemonie(), start_daemon(), stop_daemon() utility funcs.
- RPC service app constructor and service daemon.
- SPaaS Service Stack daemon
- Entrypoints for the SPaaS stack and the SPaaS RPC daemons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant