Fix handling of non-dict configs #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
reviewed
Jun 30, 2020
| @@ -110,9 +110,12 @@ def __call__(self, *args, **kwargs): | |||
| self._runner.running_task_count += 1 | |||
| self._start_time = time.monotonic() | |||
| try: | |||
| timeout_s = None | |||
| # Config can be something else than a dictionary | |||
There was a problem hiding this comment.
when would the config be something else? this seems a problem that should be handled in the caller site, and not here.
There was a problem hiding this comment.
For example in the WaitTask, the config is just an int
There was a problem hiding this comment.
The point is that it should be fixed there then.
There was a problem hiding this comment.
I guess we want to support this:
- wait: 30
instead of
- wait: {time: 30}
There was a problem hiding this comment.
I propopose to fix that later: #584
Dominik1999
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
let's merge that to get the tests run again and then work on #584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in
AttributeError: 'int' object has no attribute 'get'