Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of non-dict configs #583

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

palango
Copy link
Contributor

@palango palango commented Jun 30, 2020

As seen in AttributeError: 'int' object has no attribute 'get'

@palango palango requested a review from Dominik1999 June 30, 2020 10:34
@auto-assign auto-assign bot requested a review from hackaugusto June 30, 2020 10:35
@@ -110,9 +110,12 @@ def __call__(self, *args, **kwargs):
self._runner.running_task_count += 1
self._start_time = time.monotonic()
try:
timeout_s = None
# Config can be something else than a dictionary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would the config be something else? this seems a problem that should be handled in the caller site, and not here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example in the WaitTask, the config is just an int

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is that it should be fixed there then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we want to support this:

 - wait: 30

instead of

- wait: {time: 30}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propopose to fix that later: #584

Copy link
Contributor

@Dominik1999 Dominik1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge that to get the tests run again and then work on #584

@palango palango merged commit 8b49e5f into raiden-network:master Jul 1, 2020
@palango palango deleted the fix-wait-tasks branch July 1, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants