Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong type for polymorphic association while deserialization #2268

Open
wants to merge 1 commit into
base: 0-10-stable
Choose a base branch
from

Conversation

vivektiwary
Copy link

while deserializing any polymorphic relation, the type of the record was
coming wrong. (e.g, for a relation of type 'BlogPost', the type was
coming out as 'Blog-post'). This was happening because, we were not
converting the hyphenated 'type' to underscore. This PR will do that
before calling classify on the type.

Purpose

Changes

Caveats

Related GitHub issues

Additional helpful information

while deserializing any polymorphic relation, the type of the record was
coming wrong. (e.g, for a relation of type 'BlogPost', the type was
coming out as 'Blog-post'). This was happening because, we were not
converting the hyphenated 'type' to underscore. This PR will do that
before calling classify on the type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant