Update gem requirement to allow Rails 7.1 #2453

schinery · 2023-10-05T13:32:43Z

Purpose

Update allowed version of Rails to < 7.2.0 as they have now released 7.1.0.

Changes

Updates rails_versions in Gemspec to < 7.2
Updates CI rails-version to 7.1
Added ruby-version: '3.2' to CI tests

Related GitHub issues

Based changes on #2428 which updated from < 7.0 to < 7.1.

carltonsmith · 2023-10-05T15:44:57Z

@wasifhossain can we expect this to be merged soon? It's blocking our upgrade to rails 7.1 at the moment

active_model_serializers.gemspec

wasifhossain · 2023-10-05T16:02:47Z

unfortunately tests are failing to run on Ubuntu 18.04 stack. there's an open PR #2451 to address the issue.

could you please test this change on that branch and if tests pass, then we can merge both these PRs.

what do you think?

schinery · 2023-10-05T16:44:17Z

unfortunately tests are failing to run on Ubuntu 18.04 stack. there's an open PR #2451 to address the issue.

could you please test this change on that branch and if tests pass, then we can merge both these PRs.

what do you think?

Hey @wasifhossain, just wondering what would be your preferred way to do this:

Point this PR at the upgrade-ubuntu-on-CI branch and pull the changes in from that?
Create a new PR with these changes in from the upgrade-ubuntu-on-CI?
Something else?

schinery · 2023-10-05T16:49:21Z

In case it is option 2: #2454

bf4 · 2023-10-05T17:25:25Z

Got one failing test on ruby 2.7 and rails 7.1

schinery · 2023-10-05T18:05:44Z

Looks like the tests passed but running Rubocop failed 😢

wrong number of arguments (given 2, expected 1)
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/psych-5.1.0/lib/psych.rb:322:in `safe_load'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/config_loader.rb:164:in `yaml_safe_load'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/config_loader.rb:149:in `load_yaml_configuration'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/config_loader.rb:35:in `load_file'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/config_store.rb:24:in `options_config='
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/cli.rb:64:in `act_on_options'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/cli.rb:25:in `run'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/rake_task.rb:49:in `run_cli'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/rake_task.rb:37:in `run_main_task'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/rake_task.rb:29:in `block (2 levels) in initialize'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/file_utils_ext.rb:58:in `verbose'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rubocop-0.40.0/lib/rubocop/rake_task.rb:27:in `block in initialize'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `block in execute'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `each'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:281:in `execute'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:243:in `block in invoke_prerequisites'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `each'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:241:in `invoke_prerequisites'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:218:in `block in invoke_with_call_chain'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `synchronize'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:199:in `invoke_with_call_chain'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/task.rb:188:in `invoke'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:160:in `invoke_task'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block (2 levels) in top_level'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `each'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:116:in `block in top_level'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:125:in `run_with_threads'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:110:in `top_level'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:83:in `block in run'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/bin/rake:23:in `load'
/home/runner/work/active_model_serializers/active_model_serializers/vendor/bundle/ruby/2.7.0/bin/rake:23:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli/exec.rb:58:in `load'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli/exec.rb:58:in `kernel_load'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli/exec.rb:23:in `run'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli.rb:492:in `exec'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli.rb:34:in `dispatch'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/cli.rb:28:in `start'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/exe/bundle:37:in `block in <top (required)>'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/gems/2.7.0/gems/bundler-2.4.20/exe/bundle:29:in `<top (required)>'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `<main>'
RuboCop failed!
Running RuboCop...
Error: Process completed with exit code 1.

wasifhossain · 2023-10-05T18:30:48Z

I see. rails 7.1 is requiring psych this way

railties (7.1.0) -> irb
irb (1.8.1) -> rdoc
rdoc (6.5.0) -> psych (>= 4.0.0)

unfortunately rubocop 0.40 has issues with psych >= 4

and rdoc 6.3.3 is the last version that doesn't require psych.

so I could see the tests passing for Ruby 2.7 x Rails 7.1 with this change

diff --git a/Gemfile b/Gemfile
--- a/Gemfile
+++ b/Gemfile
@@ -88,6 +88,7 @@ end
 group :development, :test do
   if RUBY_VERSION < '3.0'
     gem 'rubocop', '~> 0.40.0', require: false
+    gem 'rdoc', '6.3.3', require: false
   else
     gem 'rubocop', '~> 1.56.0', require: false
     gem 'rubocop-minitest', '~> 0.31.0', require: false

wasifhossain · 2023-10-05T18:32:44Z

@schinery feel free to make the change in Gemfile as shared above 🍀 and see if the test matrix is back to green 💯

schinery · 2023-10-05T18:34:21Z

@wasifhossain done 3f628ba

Co-authored-by: Andreas Finger <[email protected]>

schinery · 2023-10-05T19:29:03Z

@wasifhossain @bf4 is this good to be merged?

bf4 · 2023-10-05T20:10:18Z

Great job!

jgmontoya · 2023-10-05T21:44:28Z

when could we expect this to be available in a new release in rubygems?

bf4 · 2023-10-05T23:48:59Z

@jgmontoya should be live now

bf4 · 2023-10-05T23:50:13Z

@schinery @mediafinger awesome job!

mediafinger · 2023-10-10T09:07:56Z

@bf4 I've just made a suggestion, @schinery did all the work :-)

Update gem requirement to allow Rails 7.1

6541c3e

wasifhossain mentioned this pull request Oct 5, 2023

Update active_model_serializers.gemspec #2452

Closed

mediafinger reviewed Oct 5, 2023

View reviewed changes

active_model_serializers.gemspec Outdated Show resolved Hide resolved

mjankowski mentioned this pull request Oct 5, 2023

Rails 7.1 update mastodon/mastodon#25963

Merged

schinery mentioned this pull request Oct 5, 2023

Update gem requirement to allow Rails 7.1 #2454

Closed

Merge branch '0-10-stable' into 0-10-stable

2667357

schinery requested a review from wasifhossain October 5, 2023 17:08

Add rdoc to Gemfile

3f628ba

wasifhossain approved these changes Oct 5, 2023

View reviewed changes

Remove upper limit of Rails version

511901a

Co-authored-by: Andreas Finger <[email protected]>

schinery requested a review from wasifhossain October 5, 2023 18:55

wasifhossain approved these changes Oct 5, 2023

View reviewed changes

schinery requested a review from bf4 October 5, 2023 19:01

bf4 merged commit 5456a6d into rails-api:0-10-stable Oct 5, 2023
12 checks passed

schinery deleted the 0-10-stable branch October 5, 2023 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gem requirement to allow Rails 7.1 #2453

Update gem requirement to allow Rails 7.1 #2453

schinery commented Oct 5, 2023

carltonsmith commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

schinery commented Oct 5, 2023

schinery commented Oct 5, 2023

bf4 commented Oct 5, 2023

schinery commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

schinery commented Oct 5, 2023

schinery commented Oct 5, 2023

bf4 commented Oct 5, 2023

jgmontoya commented Oct 5, 2023

bf4 commented Oct 5, 2023

bf4 commented Oct 5, 2023

mediafinger commented Oct 10, 2023

Update gem requirement to allow Rails 7.1 #2453

Update gem requirement to allow Rails 7.1 #2453

Conversation

schinery commented Oct 5, 2023

Purpose

Changes

Related GitHub issues

carltonsmith commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

schinery commented Oct 5, 2023

schinery commented Oct 5, 2023

bf4 commented Oct 5, 2023

schinery commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

wasifhossain commented Oct 5, 2023

schinery commented Oct 5, 2023

schinery commented Oct 5, 2023

bf4 commented Oct 5, 2023

jgmontoya commented Oct 5, 2023

bf4 commented Oct 5, 2023

bf4 commented Oct 5, 2023

mediafinger commented Oct 10, 2023