Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add thread_safe gem as explicit dependency #2456

Closed
wants to merge 1 commit into from
Closed

Re-add thread_safe gem as explicit dependency #2456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion active_model_serializers.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ Gem::Specification.new do |spec|
# 'i18n,
# 'tzinfo'
spec.add_development_dependency 'minitest', ['~> 5.0', '< 5.11']
# 'thread_safe'

spec.add_dependency 'thread_safe','~> 0.3', '>= 0.3.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be explicit here: add_development_dependency or add_runtime_dependency

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed when running tests against Rails 7.1 it will be needed as well as in production.


spec.add_runtime_dependency 'jsonapi-renderer', ['>= 0.1.1.beta1', '< 0.3']
spec.add_runtime_dependency 'case_transform', '>= 0.2'
Expand Down