Don't force ActionController::TestCase to load #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of referencing ActionController::TestCase directly during boot, we can use a lazy load hook to apply our mixins if it is loaded later. The action_controller_test_case load hook was added in Rails 5.1, and the run_once option was added in Rails 5.2. I've left the behaviour unchanged for older Rails versions where they're not available.
|
awesome, thanks |
bf4
reviewed
Feb 21, 2024
| @@ -44,9 +44,19 @@ class Railtie < Rails::Railtie | |||
| end | |||
| # :nocov: | |||
|
|
|||
| def extend_action_controller_test_case(&block) | |||
| if Rails::VERSION::MAJOR >= 6 || Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR >= 2 | |||
| ActiveSupport.on_load(:action_controller_test_case, run_once: true, &block) | |||
bf4
reviewed
Feb 21, 2024
| if Rails::VERSION::MAJOR >= 6 || Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR >= 2 | ||
| ActiveSupport.on_load(:action_controller_test_case, run_once: true, &block) | ||
| else | ||
| ActionController::TestCase.instance_eval(&block) |
There was a problem hiding this comment.
nice checking version support for the on load hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of referencing
ActionController::TestCasedirectly during boot, we can use a lazy load hook to apply our mixins if it is loaded later.Aside from the direct benefit of not evaluating a rather large Ruby file until necessary, this will avoid forcing other lazy load hooks to run prematurely (e.g. amatsuda/routes_lazy_routes#14).
The
action_controller_test_caseload hook was added in Rails 5.1, and therun_onceoption was added in Rails 5.2. I've left the behaviour unchanged for older Rails versions where they're not available.