[0.9 stable] Avoid Object.constants.include?
#2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an extremely inneficient way to check if a constant is defined. `Object.constants.size` is `135` in a raw irb session. On our large app, not even eager loaded it's `4521`. I didn't bother to check in production, but it's probably several times that. So here we're both allocating a very large array, and doing a `O(n)` search into it.
casperisfine
changed the title
Object.constants.include?Object.constants.include?
bf4
reviewed
Apr 11, 2024
| @@ -62,7 +62,7 @@ def serializer_for(resource, options = {}) | |||
| if resource.respond_to?(:serializer_class) | |||
| resource.serializer_class | |||
| elsif resource.respond_to?(:to_ary) | |||
| if Object.constants.include?(:ArraySerializer) | |||
| if defined?(::ArraySerializer) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely inneficient way to check if a constant is defined.
Object.constants.sizeis135in a raw irb session.On our large app, not even eager loaded it's
4521. I didn't bother to check in production, but it's probably several times that.So here we're both allocating a very large array, and doing a
O(n)search into it.cc @bf4