Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When changing columns set date-time columns to datetime(6) by default #1089

Merged
merged 1 commit into from
Sep 19, 2023
Merged

When changing columns set date-time columns to datetime(6) by default #1089

merged 1 commit into from
Sep 19, 2023

Conversation

aidanharan
Copy link
Contributor

When changing columns set date-time columns to datetime(6) by default.

Fixes failing test:
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/6234806413/job/16922729893?pr=1088

Error:
CompatibilityTest7_0#test_datetime_sets_precision_6_on_change_table:
ActiveRecord::StatementInvalid: TinyTds::Error: Conversion failed when converting date and/or time from character string.
    activerecord-sqlserver-adapter/lib/active_record/connection_adapters/sqlserver/database_statements.rb:454:in `each'
    activerecord-sqlserver-adapter/lib/active_record/connection_adapters/sqlserver/database_statements.rb:454:in `handle_to_names_and_values_dblib'

@aidanharan aidanharan marked this pull request as ready for review September 19, 2023 13:43
@aidanharan aidanharan merged commit 081cb84 into 7-0-stable Sep 19, 2023
6 checks passed
@aidanharan aidanharan deleted the fix-change-table-test branch September 19, 2023 13:43
aidanharan added a commit that referenced this pull request Sep 19, 2023
@aidanharan
When changing columns set date-time columns to datetime(6) by default (…
c2ac6d5 
…#1089)
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@aidanharan
When changing columns set date-time columns to datetime(6) by default (…
55dfb00 
…rails-sqlserver#1089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan