Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calculate monkey-patch #1090

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Update calculate monkey-patch #1090

merged 2 commits into from
Sep 19, 2023

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented Sep 19, 2023 •
edited
Loading

Fixes the failing activerecord/test/cases/null_relation_test.rb tests. Needed to copy over the changes made to the ActiveRecord::Calculations.calculate method that we monkey-patch.

Cleaned up the construct_relation_for_exists monky-patch too.

@aidanharan aidanharan marked this pull request as ready for review September 19, 2023 15:45
@aidanharan aidanharan merged commit b0dbf8f into main Sep 19, 2023
0 of 8 checks passed
@aidanharan aidanharan deleted the fix_null_relation_tests branch September 19, 2023 15:45
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@aidanharan
Update calculate monkey-patch (rails-sqlserver#1090)
cd6b8e9
@aidanharan aidanharan mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan