Singletons: Inline find_singleton back into find
#453
Merged
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
singleton-inline-find-singleton
branch
from
7254e25 to
55248a1
Compare
seanpdoyle
changed the title
find_singleton back into findfind_singleton back into find
When the Singleton module was originally introduced in [rails#4][], there was a suggestion about the implementation for `.find` that used the `:one` modifier option with the `:from` keyword argument. ```ruby class Account < ActiveResource::Base def self.find_singleton find :one, from: '/account.xml' end end ``` This commit modifies the `Singleton.find` method by inlining the private `find_singleton` method. By doing so, the implementation can invoke `super`, and rely on the built-in `instantiate_record` call provided by `Base`. This reduces the amount of duplication involved in transforming a response payload into a resource instance. [rails#4]: rails#4 [rails#4]: rails#4 (comment)
seanpdoyle
force-pushed
the
singleton-inline-find-singleton
branch
from
55248a1 to
7139ba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Singleton module was originally introduced in #4, there was a suggestion about the implementation for
.findthat used the:onemodifier option with the:fromkeyword argument.This commit modifies the
Singleton.findmethod by inlining the privatefind_singletonmethod. By doing so, the implementation can invokesuper, and rely on the built-ininstantiate_recordcall provided byBase.This reduces the amount of duplication involved in transforming a response payload into a resource instance.
Since the
Singleton.find_singletonmethod was private, this commit removes the test suite coverage that exercised the method through private message sending.