Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove approval block to run tests, lint, and annotations #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove approval block to run tests, lint, and annotations #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 28 additions & 14 deletions pipelines/buildkite-config/initial.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@
# This config is intended for running the rails/buildkite-config CI.

steps:
- block: "Review Build Script"
branches: "!main"
prompt: |
Our CI scripts run outside the docker containers, which are a necessary security layer.

Approving a build here is equivalent to copy & pasting it into a production ssh window.

Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.

- @matthewd
- group:
label: ":pipeline: buildkite-config meta-ci"
key: "meta"
Expand Down Expand Up @@ -92,7 +82,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI pipeline for the main branch with this config?

We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.

Approving a build here is equivalent to copy & pasting it into a production ssh window.

Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.

- @matthewd
- trigger: "rails-ci"
label: ":pipeline: Build Rails main with new config"
depends_on: block-rails-ci-main
Expand All @@ -108,7 +104,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI pipeline for the stable branch with this config?

We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.

Approving a build here is equivalent to copy & pasting it into a production ssh window.

Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.

- @matthewd
- trigger: "rails-ci"
label: ":pipeline: Build Rails 6-1-stable with new config"
depends_on: block-rails-ci-stable
Expand All @@ -124,7 +126,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the main branch with this config?

We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.

Approving a build here is equivalent to copy & pasting it into a production ssh window.

Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.

- @matthewd
- trigger: "rails-ci-nightly"
label: ":pipeline: Build Rails main with new nightly config"
depends_on: block-rails-ci-nightly-main
Expand All @@ -140,7 +148,13 @@ steps:
prompt: |
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the stable branch with this config?

We have a finite number of CI resources, so we want to avoid unnecessary builds.
Our CI scripts run outside the docker containers, which are a necessary security layer.

Approving a build here is equivalent to copy & pasting it into a production ssh window.

Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.

- @matthewd
- trigger: "rails-ci-nightly"
label: ":pipeline: Build Rails 6-1-stable with new nightly config"
depends_on: block-rails-ci-nightly-stable
Expand Down