This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 614
2 3 stable #6
Open
azimux
wants to merge
18
commits into
rails:master
Choose a base branch
from
azimux:2-3-stable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2 3 stable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to optional module
…dy does the 505/404 and any other that exists in public
…to action_name still requires request to be defined
…tch master. this does create a new ActionView dependency, though
Hmmm... I don't know how to make it request a pull only from my 2-3-stable into rails:2-3-stable Obviously only 1 commit should be pulled into 2-3-stable and not 17 into master |
added by ExceptionNotification::ConsiderLocal
This tripped me up for a few minutes too, good fix in 66dc72b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local_addresses doesn't exist after a "include ExceptionNotification::ConsiderLocal"
This is because self.include is defined in ExceptionNotification::ConsiderLocal::ClassMethods instead of ExceptionNotification::ConsiderLocal