Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --public-path from build_script #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove --public-path from build_script #204

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. Remove --public-path from build_script 

    The esbuild option `--public-path` is used to define absolute asset hosts for file loaders. Setting `--public-path=/assets` will interfere with downstream asset processing (for example Sprocket's AssetUrlProcessor), because the corresponding asset can't be found on disk.

Since asset urls are rewritten anyway, removing --public-path doesn't have a negative impact.

https://esbuild.github.io/api/#public-path
    @coezbek
    coezbek authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cebf336 View commit details
    Browse the repository at this point in the history