Use compact

rails · Feb 13, 2024 · eb68a92 · eb68a92
1 parent 0bf2705
commit eb68a92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/kredis/types/hash.rb b/lib/kredis/types/hash.rb
@@ -18,7 +18,7 @@ def []=(key, value)
   end
 
   def update(**entries)
-    hset entries.transform_values { |val| type_to_string(val, typed) } if entries.flatten.any?
+    hset entries.transform_values { |val| type_to_string(val, typed) }.compact if entries.flatten.any?
   end
 
   def values_at(*keys)

diff --git a/test/types/hash_test.rb b/test/types/hash_test.rb
@@ -125,9 +125,9 @@ class HashTest < ActiveSupport::TestCase
     assert_equal({ "space_invaders" => 100, "pong" => 42 }, @hash.to_h)
   end
 
-  test "does not support nil values" do
-    assert_raises do
-      @hash.update("key" => nil)
-    end
+  test "handles nil values gracefully" do
+    @hash.update("key" => nil, "key2" => "value2")
+    assert_nil @hash["key"]
+    assert_equal "value2", @hash["key2"]
   end
 end