Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop warnings #132

Closed
wants to merge 1 commit into from
Closed

Fix rubocop warnings #132

wants to merge 1 commit into from

Conversation

nzwsch
Copy link

@nzwsch nzwsch commented Nov 6, 2023

I recently made a comment urging the release of kredis.
Thank you for releasing 1.6.0.
I don't know if this is a result of that, but I noticed that the tests in the main branch are red.
Fortunately, I ran Rubocop locally and all errors were resolved.
I don't know if this qualifies as an open source contribution, but let me submit it as a PR.

Here is my output:

$ bundle exec rubocop
Inspecting 56 files
........................................................

56 files inspected, no offenses detected

@dhh
Copy link
Member

dhh commented Dec 27, 2023

I don't like any of those fixes. Should tell rubocop to ignore them instead.

@nzwsch
Copy link
Author

nzwsch commented Dec 28, 2023

We have two options.

The first is that this Rubocop rule references a rule in Rails itself, and Rails allows AssertPredicate, so we need to disable this one.
The second would be to add AssertPredicate to the .rubocop.yml file as an exception.

Which is preferred?

@dhh
Copy link
Member

dhh commented Dec 29, 2023

@dhh
Copy link
Member

dhh commented Dec 29, 2023

Fixed in 01a893b.

@dhh dhh closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants