Kredis.hash fails with nil values in Redis 5+ #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been bite several times in production by trying to set a kredis hash with the value of a key being
nil
. As we know, accidentalnil
s are not rare in Ruby :(Kredis attempts to call
hset
in redis with a nil value, which is not supported and you get this exception:This PR runs
Hash#compact
on the values passed to Kredis before trying to send them to Redis viahset
. This would remove invalid key/value pairs. Later, when reading the stored hash back, you would rely on the Ruby default return value ofnil
when accessing a non-existing key.