Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by date #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MacLove13
Copy link

@MacLove13 MacLove13 commented Nov 20, 2024

Add the options enqueued_at, scheduled_at and finished_at to where.

This will be useful to solve the PR #197 so that it can work for Solid and Resque.

And maybe more screens and/or filters in the future.

This will also make it easier for an Auto Update UI that I'm planning to build, to better track queues.

@MacLove13
Copy link
Author

Oh, I hadn't realized that there is already a PR #111 being worked on by @Xeitor

@rosa
Copy link
Member

rosa commented Nov 25, 2024

Thanks @MacLove13! Yes, I think it's better to wait until #111 is done and then build the new filters on top of it?

@rosa
Copy link
Member

rosa commented Dec 2, 2024

#111 has been merged now, so this can be built on top of that, with the new filters. That version doesn't work for Resque in any way, but in the case of finished_at it doesn't matter because Resque doesn't store finished jobs. For enqueued_at, it'd be supported in memory, and scheduled_at would need resque-scheduler and support for scheduled jobs in Resque, which is pending: #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants